You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/05/25 08:55:55 UTC
[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
robotLJW opened a new pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
tianxiaoliang edited a comment on pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003#issuecomment-848420489
datasource/cache拿出来 和datasource平级，叫datacache。cache在数据源里不合理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003#issuecomment-848422872
另外 请把bug fix和重构分开，否则合入太多，不清楚哪部分是bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003#issuecomment-848420489
datasource/cache拿出来 和datasource平级，叫datacache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] robotLJW closed pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
robotLJW closed pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003#issuecomment-848417116
- mongo/dao 里面包含持久化访问和所有的struct定义 不存在model这种pkg
- mongo/client 放db链接管理，通用数据库操作API
- mongo/util 放置通用业务方法
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1003: SCB-2176 Fix: GetConsumerIDsWithFilter version filtering problem
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1003:
URL: https://github.com/apache/servicecomb-service-center/pull/1003#discussion_r639366359
##########
File path: datasource/mongo/dep.go
##########
@@ -28,10 +28,10 @@ import (
"github.com/apache/servicecomb-service-center/datasource"
"github.com/apache/servicecomb-service-center/datasource/etcd/path"
- "github.com/apache/servicecomb-service-center/datasource/mongo/client"
- "github.com/apache/servicecomb-service-center/datasource/mongo/client/dao"
- "github.com/apache/servicecomb-service-center/datasource/mongo/client/model"
- mutil "github.com/apache/servicecomb-service-center/datasource/mongo/util"
+ "github.com/apache/servicecomb-service-center/datasource/mongo/dao"
+ "github.com/apache/servicecomb-service-center/datasource/mongo/dao/client"
Review comment:
mongo/client才是对的规划，不要把client 放到dao里
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org