You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Chia-Ping Tsai (Jira)" <ji...@apache.org> on 2020/12/23 06:02:00 UTC

[jira] [Created] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

Chia-Ping Tsai created KAFKA-10885:
--------------------------------------

             Summary: Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases
                 Key: KAFKA-10885
                 URL: https://issues.apache.org/jira/browse/KAFKA-10885
             Project: Kafka
          Issue Type: Improvement
            Reporter: Chia-Ping Tsai


{quote}

private void assumeAtLeastV2OrNotZstd(byte magic) {
 assumeTrue(compressionType != CompressionType.ZSTD || magic >= MAGIC_VALUE_V2);
}

{quote}

MemoryRecordsBuilderTest/MemoryRecordsTest use aforementioned method to avoid testing zstd on unsupported magic code. However, it produces some unnecessary ignored test cases. Personally, it could be separated to different test classes for each magic code as we do assign specify magic code to each test cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)