You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2025/07/10 15:13:21 UTC
[PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain opened a new pull request, #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142
This change adds a new set of modules which we will need for Jetty 12 migration. The code has been modularised into following modules:
- `[hbase-shaded-jetty-12-plus-core](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus-core)`: Contains shaded jetty 12 core jars
- `[hbase-shaded-jetty-12-plus-ee8](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus-ee8)`: Contains shaded jetty EE8 specific jars
So basically:
- Branches which want to consume EE8 may need to add `[hbase-shaded-jetty-12-plus-core](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus-core)` and `[hbase-shaded-jetty-12-plus-ee8](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus-ee8)` in their dependency replacing the former `[hbase-shaded-jetty](https://issues.apache.org/jira/browse/HBASE-shaded-jetty)`
- Branches which want to consume EE9/EE10 may need to add a new module for same in `[hbase-thirdparty](https://issues.apache.org/jira/browse/HBASE-thirdparty)` in future
Next, implement maven toolchains-based build system to support both JDK 8 and JDK 17 compilation in a single branch with configurable setup:
- Add toolchains plugin configuration for automatic JDK selection
- Configure Jetty 12 modules ([hbase-shaded-jetty-12-plus-](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus-)*) to use JDK 17
- Maintain JDK 8 compatibility for existing modules
- Split maven-enforcer-plugin into separate JDK 8/17 bytecode checks
- Add generate-toolchains.sh script for dynamic toolchains.xml generation
- Support JAVA8_HOME/JAVA17_HOME environment variable configuration
- Auto-detect Java installations at /usr/lib/jvm/java-8 and /usr/lib/jvm/java-17 for CI
- Force explicit environment variable setup for local development
- Remove dependency on ~/.m2/toolchains.xml for project-specific configuration
- Add documentation with setup commands and CI/local instructions
This allows HBase 2.x to continue using JDK 8 compatible Jetty 9 modules while HBase 3.x can leverage JDK 17 Jetty 12 modules, with seamless Jenkins/CI builds and clear local development setup, eliminating the need for separate branches or releases.
WIP: Jenkins change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101712047
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101659394
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222256508
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
Yes right it used `sun.misc`, here the error if we try to build with jdk17 but target set to 8 for hbase-shaded-protobuf
```
[INFO] ---------< org.apache.hbase.thirdparty:hbase-shaded-protobuf >----------
[INFO] Building Apache HBase Patched and Relocated (Shaded) Protobuf 4.1.12-SNAPSHOT [2/13]
[INFO] from hbase-shaded-protobuf/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.3.1:clean (default-clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/target
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java (includes = [**/**], excludes = [])
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/resources (includes = [**/**], excludes = [])
[INFO]
[INFO] --- flatten:1.5.0:clean (flatten.clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/.flattened-pom.xml
[INFO]
[INFO] --- toolchains:3.2.0:toolchain (default) @ hbase-shaded-protobuf ---
[INFO] Required toolchain: jdk [ version='17' ]
[INFO] Found matching toolchain for type jdk: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO]
[INFO] --- build-helper:3.4.0:regex-property (regex-property) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-maven-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-java-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (min-maven-min-java-banned-xerces) @ hbase-shaded-protobuf ---
[INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- clean:3.3.1:clean (pre-generate-sources) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- dependency:3.6.0:unpack (unpack) @ hbase-shaded-protobuf ---
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:sources:4.30.2:jar
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:4.30.2:jar
[INFO]
[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch
[INFO]
[INFO] --- remote-resources:3.1.0:process (process-resource-bundles) @ hbase-shaded-protobuf ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Copying appended resource: META-INF/LICENSE
[INFO] Copying appended resource: META-INF/NOTICE
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ hbase-shaded-protobuf ---
[INFO] Copying 12 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to target/classes
[INFO]
[INFO] --- flatten:1.5.0:flatten (flatten) @ hbase-shaded-protobuf ---
[INFO] Generating flattened POM of project org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:4.1.12-SNAPSHOT...
[INFO]
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[INFO] 19 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 2.783 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 7.424 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.565 s
[INFO] Finished at: 2025-07-22T17:06:54+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure: Compilation failure:
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2206509059
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
+ <execution>
+ <id>enforce-jdk17-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${compileSource}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>Some modules require JDK 17 bytecode compatibility.
Review Comment:
update message based on new defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2206505799
##########
README.md:
##########
@@ -92,14 +92,72 @@ modern JDKs. Due to a bug in JDK, we cannot generate this code using a more
modern version of the JDK. See
[HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details.
+## Jetty 12 and Dual JDK Requirement
+
+Starting with version 4.1.12, this project requires JDK 8 and JDK 17 to accommodate different HBase versions:
+
+- **HBase 2.x**: Uses JDK 8 compatible modules (including `hbase-shaded-jetty` with Jetty 9)
+- **HBase 3.x**: Uses JDK 17 modules (including `hbase-shaded-jetty-12-plus-*` with Jetty 12)
+
+### Why Dual JDK Support?
+
+Jetty 12 requires JDK 17 for compilation, but HBase 2.x deployments cannot move to Jetty 12 for JDK 8 compatibility. Our solution provides a single release containing modules for both JDK versions, eliminating the need for separate branches or releases.
Review Comment:
TODO: Update README to reflect new defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072256641
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/7/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux da54e3c4e060 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/7/console |
| versions | git=2.43.0 maven=3.9.10 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 [hbase-thirdparty] Add module for Jetty 12 with EE8 and add support for toolchain based JDK selection [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2244531267
##########
dev-support/generate-toolchains.sh:
##########
@@ -0,0 +1,62 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Script to generate toolchains.xml with configurable Java paths
+
+# Set default paths if environment variables are not set
Review Comment:
This is great.
The release scripts should also be amended to to call this when releasing hbase-thirdparty
(assuming that the release script supports hbase-thirdparty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216992384
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20211016 \
+ curl='7.81.0-*' \
+ locales='2.35-*' \
+ bash='5.1-*' \
+ binutils='2.38-*' \
+ build-essential=12.9ubuntu3 \
+ git='1:2.34.1-*' \
+ rsync='3.2.3-*' \
+ tar='1.34+dfsg-*' \
+ wget='1.21.2-*' \
+ shellcheck='0.8.0-*' \
+ patch='2.7.6-*' \
+ && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* \
+ && \
+ locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz /tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head -n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz /tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head -n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+ cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
Review Comment:
DISCUSS: Should I call new command as mvn_wrap and pass this as command to yetus? Not sure if this would work though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090825163
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/47/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090213589
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/13/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090152625
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 4s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/12/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090716885
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090758650
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 55s | root in master failed. |
| -1 :x: | compile | 0m 5s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 3s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 3s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 4m 36s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 2a76debe288b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090663299
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 0s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/31/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090691843
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 3s | root in master failed. |
| -1 :x: | compile | 0m 3s | root in master failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 3s | root in master failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 3s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 3s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 3s | root in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 3s | root in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. |
| +0 :ok: | asflicense | 0m 17s | ASF License check generated no output? |
| | | 2m 39s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 02182c88c6f7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/jenkins/personality.sh |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/testReport/ |
| Max. process+thread count | 35 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-protobuf hbase-unsafe U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090224317
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/14/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090400865
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993856
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20211016 \
+ curl='7.81.0-*' \
+ locales='2.35-*' \
+ bash='5.1-*' \
+ binutils='2.38-*' \
+ build-essential=12.9ubuntu3 \
+ git='1:2.34.1-*' \
+ rsync='3.2.3-*' \
+ tar='1.34+dfsg-*' \
+ wget='1.21.2-*' \
+ shellcheck='0.8.0-*' \
+ patch='2.7.6-*' \
+ && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* \
+ && \
+ locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz /tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head -n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz /tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head -n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+ cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@" -t "$TOOLCHAIN"
+else
+ echo "Unexpected: ${TOOLCHAIN} file is missing!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@"
+fi
+EOF
+RUN chmod +x /opt/maven/bin/mvn && cat /opt/maven/bin/mvn
Review Comment:
drop cat /opt/maven/bin/mvn now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217146867
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
Review Comment:
yes yes right need to change docs comments everywhere as per current implementation, still todo. let me fox these and make pr non draft today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225552542
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
Review Comment:
Just out of curiosity: Is there a specific reason why we would like to use 22.04 'Jammy Jellyfish' (LTS)?
It is a bit older Ubuntu version, we might consider newer version, for example: 24.04 'Noble Numbat' (LTS).
Checking at https://hub.docker.com/_/ubuntu 22.04 is also a supported version though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222326562
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
> Should I remove from main pom.xml and just set below explicitly for jdk 8 modules?
>
> ```
> <maven.compiler.source>${java.release.version}</maven.compiler.source>
> <maven.compiler.target>${java.release.version}</maven.compiler.target>
> ```
Updated PR to remove compiler source and target from main pom.xml and moved to only reqd modules!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222270829
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
If I do not set them it fails for with error:
```
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Users/nihjain/adoptopenjdk-8.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] [options] bootstrap class path not set in conjunction with -source 1.7
[INFO] 1 warning
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33] error: lambda expressions are not supported in -source 1.7
(use -source 8 or higher to enable lambda expressions)
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 1.254 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 5.708 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.207 s
[INFO] Finished at: 2025-07-22T17:13:58+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33] error: lambda expressions are not supported in -source 1.7
[ERROR] (use -source 8 or higher to enable lambda expressions)
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 [hbase-thirdparty] Add module for Jetty 12 with EE8 and add support for toolchain based JDK selection [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3057928863
Hi reviewers, requesting you for early feedback here, before I move ahead with Jenkins integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072304896
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/8/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux 5c1f356d5305 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/8/console |
| versions | git=2.43.0 maven=3.9.10 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3073096837
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2203688521
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
Review Comment:
It depends on the docker image we use, need to check the yetus command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2198030797
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
Review Comment:
Need to figure out how to run script here and pass tool chain path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090377657
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 0s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 3s | root in master failed. |
| -1 :x: | compile | 0m 2s | root in master failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 2s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 2s | root in master failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 3s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 0s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 2s | root in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 2s | root in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 5 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 2s | root in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 2s | root in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-unsafe in the patch failed. |
| +0 :ok: | asflicense | 0m 12s | ASF License check generated no output? |
| | | 1m 56s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux 2d59b36d70e6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/testReport/ |
| Max. process+thread count | 24 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-protobuf hbase-unsafe U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/console |
| versions | git=2.34.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090367962
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 1s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 2s | root in master failed. |
| -1 :x: | compile | 0m 2s | root in master failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 2s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 3s | root in master failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 2s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 1s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 2s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 2s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 3s | root in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 3s | root in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 5 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 2s | root in the patch failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 2s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 2s | root in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 2s | hbase-unsafe in the patch failed. |
| +0 :ok: | asflicense | 0m 11s | ASF License check generated no output? |
| | | 1m 55s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux a62563b4911c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/testReport/ |
| Max. process+thread count | 15 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-protobuf hbase-unsafe U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/console |
| versions | git=2.34.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090824313
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 37s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 14s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 3s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 4m 8s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 0c529abef9ef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/console |
| versions | git=2.34.1 maven=PROJECT_NAME=unknown shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090817750
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3089652964
Any updates here? @NihalJain
Let's move forward to speed up the 3.0.0-beta-2 release.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993155
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
bump to 3.13.0 as it allows to use release with jdk 8 as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222309750
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
sure will rename as java.version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222754666
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though; although it doesnot fail build anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090402644
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -1 :x: | yetus | 0m 2s | Unprocessed flag(s): --mvn-opts |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222283619
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <hbase.unsafe.and.protobuf.java.version>1.8</hbase.unsafe.and.protobuf.java.version>
+ <java.secondary.version>17</java.secondary.version>
+ <java.release.version>8</java.release.version>
+ <maven.compiler.source>${java.release.version}</maven.compiler.source>
Review Comment:
duplicates https://github.com/apache/hbase-thirdparty/pull/142/files#r2216993155, answered there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101382918
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 1m 0s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 24s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed |
| -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 27s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 8s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 7m 39s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 3ec8e5f798a4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/testReport/ |
| Max. process+thread count | 403 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101683966
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 58s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 19s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| -1 :x: | javac | 0m 12s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 10s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 7m 18s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux d9b68afbc552 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/testReport/ |
| Max. process+thread count | 418 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222754666
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though, just doesnot fail anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222256508
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
Yes right, here the error if we try to build with jdk17 but target set to 8 for hbase-shaded-pro
[INFO] ---------< org.apache.hbase.thirdparty:hbase-shaded-protobuf >----------
[INFO] Building Apache HBase Patched and Relocated (Shaded) Protobuf 4.1.12-SNAPSHOT [2/13]
[INFO] from hbase-shaded-protobuf/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.3.1:clean (default-clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/target
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java (includes = [**/**], excludes = [])
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/resources (includes = [**/**], excludes = [])
[INFO]
[INFO] --- flatten:1.5.0:clean (flatten.clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/.flattened-pom.xml
[INFO]
[INFO] --- toolchains:3.2.0:toolchain (default) @ hbase-shaded-protobuf ---
[INFO] Required toolchain: jdk [ version='17' ]
[INFO] Found matching toolchain for type jdk: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO]
[INFO] --- build-helper:3.4.0:regex-property (regex-property) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-maven-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-java-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (min-maven-min-java-banned-xerces) @ hbase-shaded-protobuf ---
[INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- clean:3.3.1:clean (pre-generate-sources) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- dependency:3.6.0:unpack (unpack) @ hbase-shaded-protobuf ---
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:sources:4.30.2:jar
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:4.30.2:jar
[INFO]
[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch
[INFO]
[INFO] --- remote-resources:3.1.0:process (process-resource-bundles) @ hbase-shaded-protobuf ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Copying appended resource: META-INF/LICENSE
[INFO] Copying appended resource: META-INF/NOTICE
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ hbase-shaded-protobuf ---
[INFO] Copying 12 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to target/classes
[INFO]
[INFO] --- flatten:1.5.0:flatten (flatten) @ hbase-shaded-protobuf ---
[INFO] Generating flattened POM of project org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:4.1.12-SNAPSHOT...
[INFO]
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[INFO] 19 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 2.783 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 7.424 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.565 s
[INFO] Finished at: 2025-07-22T17:06:54+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure: Compilation failure:
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuftobuf:
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090810629
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 36s | root in master failed. |
| -1 :x: | compile | 0m 5s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 5m 29s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 3157dcb59464 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090772802
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/40/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216992384
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20211016 \
+ curl='7.81.0-*' \
+ locales='2.35-*' \
+ bash='5.1-*' \
+ binutils='2.38-*' \
+ build-essential=12.9ubuntu3 \
+ git='1:2.34.1-*' \
+ rsync='3.2.3-*' \
+ tar='1.34+dfsg-*' \
+ wget='1.21.2-*' \
+ shellcheck='0.8.0-*' \
+ patch='2.7.6-*' \
+ && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* \
+ && \
+ locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz /tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head -n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz /tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head -n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+ cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
Review Comment:
DISCUSS: Should I call new command as mvn_wrap and pass this as command to yetus?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090830734
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217146867
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
Review Comment:
yes ues right need to change docs comments everywhere as per current implementation, still todo. let me fox these and make pr non draft today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3073127710
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2198150525
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
Review Comment:
I copied these values from hbase main repo, I don't have much knowledge of CI defaults and Jenkinsfile management; if someone could guide me here it will be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2198150525
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
Review Comment:
I copied these values from hbase main repo, I don't have much knowledge of Jenkinsfile management; if someone could guide me here it will be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072303531
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/8/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3073137274
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 36s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 11s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | root in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 4 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 3s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 3m 20s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux edd11e295eff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/10/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090427176
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993856
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20211016 \
+ curl='7.81.0-*' \
+ locales='2.35-*' \
+ bash='5.1-*' \
+ binutils='2.38-*' \
+ build-essential=12.9ubuntu3 \
+ git='1:2.34.1-*' \
+ rsync='3.2.3-*' \
+ tar='1.34+dfsg-*' \
+ wget='1.21.2-*' \
+ shellcheck='0.8.0-*' \
+ patch='2.7.6-*' \
+ && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* \
+ && \
+ locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz /tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head -n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz /tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head -n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+ cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@" -t "$TOOLCHAIN"
+else
+ echo "Unexpected: ${TOOLCHAIN} file is missing!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@"
+fi
+EOF
+RUN chmod +x /opt/maven/bin/mvn && cat /opt/maven/bin/mvn
Review Comment:
drop cat /opt/maven/bin/mvn now? or let it be here as it is easy to debug and see what the file looks like!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216997781
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
IMPORTANT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217109468
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
+ <releaseTarget>8</releaseTarget>
Review Comment:
Oh, we already have a releaseTarget, then I suggest we just change the java.min.version to hbase.unsafe.java.version.
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
Review Comment:
Should be 8 or 1.8?
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
Review Comment:
The comment is incorrect.
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
Review Comment:
JDK17 bytecode for jetty module only :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090213958
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 5s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/13/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090628881
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 1s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 38s | root in master failed. |
| -1 :x: | compile | 0m 7s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 17s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 4m 19s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 76e90ac113c9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/jenkins/personality.sh |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090724659
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 3s | root in master failed. |
| -1 :x: | compile | 0m 4s | root in master failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 3s | root in master failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 18s | root generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | unit | 0m 48s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 4m 28s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 1c7726f12440 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/testReport/ |
| Max. process+thread count | 402 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090743043
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/38/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2198134403
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
+ JAVA8_HOME = "/usr/lib/jvm/java-8"
+ JAVA17_HOME = "/usr/lib/jvm/java-17
Review Comment:
oops close "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222762171
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
> yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though, just doesnot fail anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8
OK, if it is does not fail I think the current solution is fine. We set --release in parent, and for the two modules which needs to be built with JDK8, we set source and target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3109887918
Thank you Duo and David for the approvals, will wait another day and merge this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225658368
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
Review Comment:
Thanks, then we can leave it as it is. :ok_hand:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225644761
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
Review Comment:
hey david, just sticked to what is being used in hbase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101703481
XML not sure what is the problem.
TODO: Javac need to check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090283083
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090599035
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/27/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090725539
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/37/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2207111802
##########
pom.xml:
##########
@@ -247,8 +278,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>${compileSource}</source>
+ <target>${compileSource}</target>
Review Comment:
Oh, this is incorrect, we still need to generate the java 8 bytecode. For JDK version higher than 1.8, we could use '--release 8' to force it genereate the java 8 byte code and also use the symbols from JDK8.
The only difference is hbase-unsafe, because it depends on jdk.unsupported, which is not supported at compile time in JDK17, so we need to use JDK8 to compile it, and set source and target here.
##########
pom.xml:
##########
@@ -125,8 +127,15 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <compileSource>17</compileSource>
Review Comment:
We'd better use `--release 8` for all modules expect hbase-unsafe. For hbase-unsafe, we should use JDK8 to compile it, and set compileSource and compileTarget to 8.
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
Review Comment:
We still need to enforce jdk8 byte code for all modules, expect the new jetty 12 module, as explained above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3073112799
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 51s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 1s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 44s | root in master failed. |
| -1 :x: | compile | 0m 5s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 11s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 4 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 5m 4s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux 4b53dcf14afe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/9/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090339561
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 41s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 16s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 5s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 5s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 5 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 5s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 4m 17s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux 8351b94e5c4f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090148382
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 6s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/11/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090545767
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090663248
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/31/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993155
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
note: bumped to 3.13.0 as it allows to use release with jdk 8 as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216994170
##########
README.md:
##########
@@ -92,14 +92,72 @@ modern JDKs. Due to a bug in JDK, we cannot generate this code using a more
modern version of the JDK. See
[HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details.
+## Jetty 12 and Dual JDK Requirement
+
+Starting with version 4.1.12, this project requires JDK 8 and JDK 17 to accommodate different HBase versions:
+
+- **HBase 2.x**: Uses JDK 8 compatible modules (including `hbase-shaded-jetty` with Jetty 9)
+- **HBase 3.x**: Uses JDK 17 modules (including `hbase-shaded-jetty-12-plus-*` with Jetty 12)
+
+### Why Dual JDK Support?
+
+Jetty 12 requires JDK 17 for compilation, but HBase 2.x deployments cannot move to Jetty 12 for JDK 8 compatibility. Our solution provides a single release containing modules for both JDK versions, eliminating the need for separate branches or releases.
+
+### Why toolchains are required?
+Maven needs explicit toolchain configuration to automatically select JDK 8 for existing modules and JDK 17 for Jetty 12 modules. Environment variables alone are insufficient.
+
+### Files
+- `generate-toolchains.sh` - Script to generate toolchains.xml with configurable paths
+- `toolchains.xml` - Generated Maven toolchains configuration file (not checked in)
+
## Build/Deploy
-To build, make sure that your environment uses JDK8, then just run:
+### Local Development Setup
+
+1. **Install both JDK versions**: JDK 8 and JDK 17
+2. **Set environment variables**:
+ ```sh
+ export JAVA8_HOME=/path/to/your/jdk8
+ export JAVA17_HOME=/path/to/your/jdk17
+ ```
+3. **Choose your toolchain setup approach** (see options below)
+
+### Toolchain Setup Options
+
+**Option 1: Project-local toolchains.xml**
+```sh
+# Generate and use project-specific toolchains
+export JAVA8_HOME=/path/to/your/jdk8
+export JAVA17_HOME=/path/to/your/jdk17
+./dev-support/generate-toolchains.sh
+
+mvn clean install -t toolchains.xml
+```
+
+**Option 2: Global Maven toolchains setup**
+```sh
+# Setup toolchains in ~/.m2/ directory
+export JAVA8_HOME=/path/to/your/jdk8
+export JAVA17_HOME=/path/to/your/jdk17
+./dev-support/generate-toolchains.sh
+cp toolchains.xml ~/.m2/toolchains.xml
+mvn clean install
+```
+
+### CI/Jenkins Setup
+
+For Jenkins/CI environments, the project auto-detects Java installations at standard paths:
Review Comment:
update based on implementation/hack!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217109148
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
I suggest we change the java.min.version to something like 'java.release.version', and set it to 8. And introduce a special property like 'hbase.unsafe.java.version', and set it to 1.8.
So we can use java.version or jdk.version as the name for this property and set it 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222767563
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
Yes the implementation is same as you explained and it works fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221350077
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3102498398
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 56s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 17s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| -1 :x: | javac | 0m 12s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 7s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 15s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 27s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 44s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 6m 56s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux b1657e36ec46 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/testReport/ |
| Max. process+thread count | 416 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072248428
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/6/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux a212a0a57bb6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/6/console |
| versions | git=2.43.0 maven=3.9.10 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090296284
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/17/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090894213
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221228029
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
+ <releaseTarget>8</releaseTarget>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090361990
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/20/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090423513
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090668688
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/33/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090694095
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090746695
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090425454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| -1 :x: | maven | 0m 3s | ERROR: maven was not available. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux ebbc955b8a52 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 [hbase-thirdparty] Add module for Jetty 12 with EE8 and add support for toolchain based JDK selection [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2249201033
##########
dev-support/generate-toolchains.sh:
##########
@@ -0,0 +1,62 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Script to generate toolchains.xml with configurable Java paths
+
+# Set default paths if environment variables are not set
Review Comment:
Created HBASE-29490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101677161
Code is ready for review. CC: @Apache9 @stoty @ndimiduk @apurtell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222108566
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <hbase.unsafe.and.protobuf.java.version>1.8</hbase.unsafe.and.protobuf.java.version>
+ <java.secondary.version>17</java.secondary.version>
+ <java.release.version>8</java.release.version>
+ <maven.compiler.source>${java.release.version}</maven.compiler.source>
Review Comment:
This is for hbase-unsafe only? It should be 8 or 1.8?
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
So protobuf also uses Unsafe? What is the compile error you see?
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
Then do we still need to set maven.compiler.source and maven.compiler.target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222256508
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
Yes right it used `sun.misc.Unsafe`. Refer https://github.com/protocolbuffers/protobuf/blob/00c3c30cbc82bf951cb48ecc9eaf18ae491378ee/java/core/src/main/java/com/google/protobuf/MessageSchema.java#L93
And here is the error if we try to build with jdk17 set in toolchain, but target set to 8 for hbase-shaded-protobuf
```
[INFO] ---------< org.apache.hbase.thirdparty:hbase-shaded-protobuf >----------
[INFO] Building Apache HBase Patched and Relocated (Shaded) Protobuf 4.1.12-SNAPSHOT [2/13]
[INFO] from hbase-shaded-protobuf/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.3.1:clean (default-clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/target
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java (includes = [**/**], excludes = [])
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/resources (includes = [**/**], excludes = [])
[INFO]
[INFO] --- flatten:1.5.0:clean (flatten.clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/.flattened-pom.xml
[INFO]
[INFO] --- toolchains:3.2.0:toolchain (default) @ hbase-shaded-protobuf ---
[INFO] Required toolchain: jdk [ version='17' ]
[INFO] Found matching toolchain for type jdk: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO]
[INFO] --- build-helper:3.4.0:regex-property (regex-property) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-maven-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-java-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (min-maven-min-java-banned-xerces) @ hbase-shaded-protobuf ---
[INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- clean:3.3.1:clean (pre-generate-sources) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- dependency:3.6.0:unpack (unpack) @ hbase-shaded-protobuf ---
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:sources:4.30.2:jar
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:4.30.2:jar
[INFO]
[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch
[INFO]
[INFO] --- remote-resources:3.1.0:process (process-resource-bundles) @ hbase-shaded-protobuf ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Copying appended resource: META-INF/LICENSE
[INFO] Copying appended resource: META-INF/NOTICE
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ hbase-shaded-protobuf ---
[INFO] Copying 12 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to target/classes
[INFO]
[INFO] --- flatten:1.5.0:flatten (flatten) @ hbase-shaded-protobuf ---
[INFO] Generating flattened POM of project org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:4.1.12-SNAPSHOT...
[INFO]
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[INFO] 19 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 2.783 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 7.424 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.565 s
[INFO] Finished at: 2025-07-22T17:06:54+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure: Compilation failure:
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222318266
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
> We do not need to use java 8 for protobuf?
Sorry? But we are already doing that. We are using java 8 for unsafe and protobuf both.
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
> sure will rename as java.version
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2207130505
##########
pom.xml:
##########
@@ -125,8 +127,15 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <compileSource>17</compileSource>
Review Comment:
Got it, we just want to compile with jdk17 and set release target as jdk8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3071979237
> We only need to use JDK8 for compiling [hbase-unsafe](https://issues.apache.org/jira/browse/HBASE-unsafe), for other modules, it is OK to use JDK17 to compile and set --release to 8.
>
> Maybe we could set the default JDK version to 17, and use JDK8 for [hbase-unsafe](https://issues.apache.org/jira/browse/HBASE-unsafe) only.
Thank you Duo for the feedback, sounds good to me. Let me update PR with the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3058070428
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile markdownlint |
| uname | Linux 1d334829be33 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/2/console |
| versions | git=2.43.0 maven=3.9.10 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090705556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 3s | root in master failed. |
| -1 :x: | compile | 0m 4s | root in master failed. |
| -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 3s | root in master failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 18s | root generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | unit | 0m 49s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 4m 31s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux f4806f4cebbf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/testReport/ |
| Max. process+thread count | 405 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090428858
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| -1 :x: | maven | 0m 3s | ERROR: maven was not available. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 62b8883b6ef2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090420005
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/23/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090653824
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 4s | root in master failed. |
| -1 :x: | compile | 0m 4s | root in master failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in master failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in master failed. |
| -1 :x: | javadoc | 0m 4s | root in master failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in master failed. |
| -1 :x: | javadoc | 0m 5s | hbase-unsafe in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 3s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 3s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 3s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| +0 :ok: | asflicense | 0m 20s | ASF License check generated no output? |
| | | 3m 8s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 2e59bb279b17 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/jenkins/personality.sh |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/branch-javadoc-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/testReport/ |
| Max. process+thread count | 46 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-protobuf hbase-unsafe U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090648254
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090955690
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 36s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 14s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 16s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed |
| -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 6s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 6m 26s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux b3742e966585 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/testReport/ |
| Max. process+thread count | 416 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 [hbase-thirdparty] Add module for Jetty 12 with EE8 and add support for toolchain based JDK selection [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2245650477
##########
dev-support/generate-toolchains.sh:
##########
@@ -0,0 +1,62 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Script to generate toolchains.xml with configurable Java paths
+
+# Set default paths if environment variables are not set
Review Comment:
Hi @stoty yes you are absolutely right, release script would need some patching to understanding toolchains. Will take this up as part of release process. Thanks for highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101718586
> TODO: Javac need to check!
Javac warnings are expected, not sure why we are seeing now. Was it not coming before w/o this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222256508
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
Yes right, here the error if we try to build with jdk17 but target set to 8 for hbase-shaded-protobuf
```
[INFO] ---------< org.apache.hbase.thirdparty:hbase-shaded-protobuf >----------
[INFO] Building Apache HBase Patched and Relocated (Shaded) Protobuf 4.1.12-SNAPSHOT [2/13]
[INFO] from hbase-shaded-protobuf/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.3.1:clean (default-clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/target
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java (includes = [**/**], excludes = [])
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/resources (includes = [**/**], excludes = [])
[INFO]
[INFO] --- flatten:1.5.0:clean (flatten.clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/.flattened-pom.xml
[INFO]
[INFO] --- toolchains:3.2.0:toolchain (default) @ hbase-shaded-protobuf ---
[INFO] Required toolchain: jdk [ version='17' ]
[INFO] Found matching toolchain for type jdk: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO]
[INFO] --- build-helper:3.4.0:regex-property (regex-property) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-maven-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-java-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (min-maven-min-java-banned-xerces) @ hbase-shaded-protobuf ---
[INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- clean:3.3.1:clean (pre-generate-sources) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- dependency:3.6.0:unpack (unpack) @ hbase-shaded-protobuf ---
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:sources:4.30.2:jar
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:4.30.2:jar
[INFO]
[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch
[INFO]
[INFO] --- remote-resources:3.1.0:process (process-resource-bundles) @ hbase-shaded-protobuf ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Copying appended resource: META-INF/LICENSE
[INFO] Copying appended resource: META-INF/NOTICE
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ hbase-shaded-protobuf ---
[INFO] Copying 12 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to target/classes
[INFO]
[INFO] --- flatten:1.5.0:flatten (flatten) @ hbase-shaded-protobuf ---
[INFO] Generating flattened POM of project org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:4.1.12-SNAPSHOT...
[INFO]
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[INFO] 19 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 2.783 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 7.424 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.565 s
[INFO] Finished at: 2025-07-22T17:06:54+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure: Compilation failure:
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222327795
##########
pom.xml:
##########
@@ -125,8 +127,17 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <hbase.unsafe.and.protobuf.java.version>1.8</hbase.unsafe.and.protobuf.java.version>
Review Comment:
Question: any better name suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221350476
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3103076181
And the javac output are all warnings, not sure why yetus report it as error...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222105563
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
We do not need to use java 8 for protobuf?
And this should be java.version instead of java.secondary.version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3057914076
Add back reverted commit 6016e75d38312c9e78a4594d363c29ce24b82bc4
Also addresses HBASE-29354 i.e. https://github.com/apache/hbase-thirdparty/pull/139 /
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090224548
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 5s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/14/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090295197
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 1s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 46s | root in master failed. |
| -1 :x: | compile | 0m 7s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 17s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 19s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 5s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 5 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 5s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 5s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 5m 51s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux 85f017fc7381 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/testReport/ |
| Max. process+thread count | 52 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/16/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090308019
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090665573
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 0s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/32/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090665523
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/32/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090687485
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993419
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
is this name fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090152364
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/12/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090316889
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 40s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 16s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 4s | root in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 4s | root in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 4s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 5 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 4m 15s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile markdownlint |
| uname | Linux f807ac33a9a0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/testReport/ |
| Max. process+thread count | 45 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/18/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090328505
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/19/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090745695
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 1s | Docker mode activated. |
| -1 :x: | docker | 1m 20s | Docker failed to build yetus/unknown:0b6e052. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/38/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222739654
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
I think this means java 8 still do not support --release option? Let me check how we deal with this in hbase2...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101735103
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 37s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 15s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 18s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 7s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 6s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 48s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 6m 34s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux e4a665868e12 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/testReport/ |
| Max. process+thread count | 415 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3103061699
What is our yetus version? In java 17 we do not have js script engine, IIRC we switch to use xmllint to check xml format in newer version of yetus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222753284
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
OK, we use two profiles to do this...
https://github.com/apache/hbase/blob/5100735657c7f5ab5a23404c2a002e2ec8ccb0d9/pom.xml#L3011
I'm not sure whether this works for multi jdk build here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090854255
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 36s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 14s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 18s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed |
| -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) |
| -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) |
| -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. |
| +1 :green_heart: | unit | 0m 53s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 6m 39s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux 4ae443d3d5c4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt |
| whitespace | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/whitespace-eol.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/xml.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/testReport/ |
| Max. process+thread count | 418 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/console |
| versions | git=2.34.1 maven=file shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222256508
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-protobuf.
Review Comment:
Yes right, here the error if we try to build with jdk17 but target set to 8 for hbase-shaded-protobuf
````
[INFO] ---------< org.apache.hbase.thirdparty:hbase-shaded-protobuf >----------
[INFO] Building Apache HBase Patched and Relocated (Shaded) Protobuf 4.1.12-SNAPSHOT [2/13]
[INFO] from hbase-shaded-protobuf/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.3.1:clean (default-clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/target
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java (includes = [**/**], excludes = [])
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/resources (includes = [**/**], excludes = [])
[INFO]
[INFO] --- flatten:1.5.0:clean (flatten.clean) @ hbase-shaded-protobuf ---
[INFO] Deleting /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/.flattened-pom.xml
[INFO]
[INFO] --- toolchains:3.2.0:toolchain (default) @ hbase-shaded-protobuf ---
[INFO] Required toolchain: jdk [ version='17' ]
[INFO] Found matching toolchain for type jdk: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO]
[INFO] --- build-helper:3.4.0:regex-property (regex-property) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-maven-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (enforce-java-version) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- enforcer:3.4.1:enforce (min-maven-min-java-banned-xerces) @ hbase-shaded-protobuf ---
[INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- clean:3.3.1:clean (pre-generate-sources) @ hbase-shaded-protobuf ---
[INFO]
[INFO] --- dependency:3.6.0:unpack (unpack) @ hbase-shaded-protobuf ---
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:sources:4.30.2:jar
[INFO] Configured Artifact: com.google.protobuf:protobuf-java:4.30.2:jar
[INFO]
[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch
[INFO]
[INFO] --- remote-resources:3.1.0:process (process-resource-bundles) @ hbase-shaded-protobuf ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Copying appended resource: META-INF/LICENSE
[INFO] Copying appended resource: META-INF/NOTICE
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ hbase-shaded-protobuf ---
[INFO] Copying 12 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to target/classes
[INFO]
[INFO] --- flatten:1.5.0:flatten (flatten) @ hbase-shaded-protobuf ---
[INFO] Generating flattened POM of project org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:4.1.12-SNAPSHOT...
[INFO]
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/Library/Java/JavaVirtualMachines/openjdk-17.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[INFO] 19 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 2.783 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 7.424 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.565 s
[INFO] Finished at: 2025-07-22T17:06:54+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure: Compilation failure:
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[93,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[21,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[266,17] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[458,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[460,27] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[589,30] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[729,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[854,36] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[267,12] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[271,52] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[273,31] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,32] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/UnsafeUtil.java:[274,53] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[400,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[1469,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[2093,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3736,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3768,18] error: package sun.misc does not exist
[ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/MessageSchema.java:[3938,18] error: package sun.misc does not exist
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3102471844
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072253222
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/7/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2198030797
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -53,7 +53,9 @@ pipeline {
DOCKERFILE_REL = "${SRC_REL}/dev-support/jenkins/Dockerfile"
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = '*.dump'
- SET_JAVA_HOME = '/opt/java/openjdk'
+ SET_JAVA_HOME = "/usr/lib/jvm/java-8"
Review Comment:
Need to figure out how to run script here and pass tool chain path. Are we ok to copy to `~/.m2` in jenkins? Is this even possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090148164
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/11/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090799397
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090371318
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/21/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090655012
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/30/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2206509059
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
+ <!-- JDK 8 enforcement for hbase-unsafe module only-->
+ <execution>
+ <id>enforce-jdk8-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.min.version}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
+ <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version is active.
Non-release builds can temporarily build with a newer JDK version by setting the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean package).</message>
- </enforceBytecodeVersion>
- </rules>
- </configuration>
+ </enforceBytecodeVersion>
+ </rules>
+ <skip>${skipJdk8BytecodeCheck}</skip>
+ </configuration>
+ </execution>
+ <!-- JDK 17 enforcement for all modules except hbase-unsafe -->
+ <execution>
+ <id>enforce-jdk17-bytecode</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>verify</phase>
+ <configuration>
+ <rules>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${compileSource}</maxJdkVersion>
+ <ignoreClasses>
+ <ignoreClass>module-info</ignoreClass>
+ </ignoreClasses>
+ <ignoreOptionals>true</ignoreOptionals>
+ <ignoredScopes>
+ <ignoredScope>test</ignoredScope>
+ </ignoredScopes>
+ <message>Some modules require JDK 17 bytecode compatibility.
Review Comment:
update message based on new defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090828003
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/48/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090559814
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 0s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | hadolint was not available. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 58s | root in master failed. |
| -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. |
| -1 :x: | compile | 0m 19s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 23s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 5s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | mvninstall | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 6s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | mvninstall | 0m 5s | hbase-unsafe in the patch failed. |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 5s | hbase-unsafe in the patch failed. |
| -1 :x: | compile | 0m 5s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 5s | hbase-unsafe in the patch failed. |
| -1 :x: | javac | 0m 5s | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). |
| -1 :x: | javadoc | 0m 5s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | javadoc | 0m 7s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javadoc | 0m 5s | hbase-unsafe in the patch failed. |
| -1 :x: | javadoc | 0m 4s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 5s | hbase-shaded-protobuf in the patch failed. |
| -1 :x: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. |
| -1 :x: | unit | 0m 5s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 5m 53s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | dev-support/toolchains-jenkins.xml |
| | hbase-shaded-jetty-12-plus-core/pom.xml |
| | hbase-shaded-jetty-12-plus-ee8/pom.xml |
| | hbase-shaded-protobuf/pom.xml |
| | hbase-unsafe/pom.xml |
| | pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint |
| uname | Linux f7ab5dfdc2f6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/jenkins/personality.sh |
| git revision | master / 1e93a44 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-unsafe.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-hbase-unsafe.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/xml.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-javadoc-hbase-unsafe.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-unit-hbase-unsafe.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/testReport/ |
| Max. process+thread count | 47 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-protobuf hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-unsafe . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/console |
| versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090618450
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2207129179
##########
pom.xml:
##########
@@ -519,28 +573,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
- <rules>
- <enforceBytecodeVersion>
- <maxJdkVersion>${compileSource}</maxJdkVersion>
- <ignoreClasses>
- <ignoreClass>module-info</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.SubmissionPublisher*</ignoreClass>
- <ignoreClass>**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*</ignoreClass>
- </ignoreClasses>
- <ignoreOptionals>true</ignoreOptionals>
- <ignoredScopes>
- <ignoredScope>test</ignoredScope>
- </ignoredScopes>
- <message>HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version ${compileSource} or earlier
+ <executions>
Review Comment:
ah okay sure let me take care of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221213842
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
Sure let me update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101362243
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222318266
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
> We do not need to use java 8 for protobuf?
Sorry? But we are already doing that. We are using java 8 for unsafe and protobuf both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221738494
##########
dev-support/jenkins/Dockerfile:
##########
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20211016 \
+ curl='7.81.0-*' \
+ locales='2.35-*' \
+ bash='5.1-*' \
+ binutils='2.38-*' \
+ build-essential=12.9ubuntu3 \
+ git='1:2.34.1-*' \
+ rsync='3.2.3-*' \
+ tar='1.34+dfsg-*' \
+ wget='1.21.2-*' \
+ shellcheck='0.8.0-*' \
+ patch='2.7.6-*' \
+ && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* \
+ && \
+ locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz /tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head -n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz /tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head -n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+ cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@" -t "$TOOLCHAIN"
+else
+ echo "Unexpected: ${TOOLCHAIN} file is missing!"
+ exec ${MAVEN_HOME}/bin/mvn-original "$@"
+fi
+EOF
+RUN chmod +x /opt/maven/bin/mvn && cat /opt/maven/bin/mvn
Review Comment:
I think its okay to keep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221225477
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222282459
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
Should I remove from main pom.xml and just set below explicitly for jdk 8 modules?
```
<maven.compiler.source>${java.release.version}</maven.compiler.source>
<maven.compiler.target>${java.release.version}</maven.compiler.target>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3072212869
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 56s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/5/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 |
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile markdownlint |
| uname | Linux e5161408e352 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 1e93a44 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/5/console |
| versions | git=2.43.0 maven=3.9.10 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3089766516
> Any updates here? @NihalJain Let's move forward to speed up the 3.0.0-beta-2 release.
>
> Thanks.
Hi @Apache9 let me put up an update tomorrow was caught up with some other work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org