Re: svn commit: r1898524 - in /subversion/trunk/subversion: svn/help-cmd.c tests/cmdline/getopt_tests_data/svn--version--verbose_stdout tests/cmdline/getopt_tests_data/svn--version_stdout

[Daniel Sahlberg <da...@gmail.com>]

Den ons 2 mars 2022 12:04 <ju...@apache.org> skrev:

> Modified:
> subversion/trunk/subversion/tests/cmdline/getopt_tests_data/svn--version_stdout
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/getopt_tests_data/svn--version_stdout?rev=1898524&r1=1898523&r2=1898524&view=diff
>
> ==============================================================================
> ---
> subversion/trunk/subversion/tests/cmdline/getopt_tests_data/svn--version_stdout
> (original)
> +++
> subversion/trunk/subversion/tests/cmdline/getopt_tests_data/svn--version_stdout
> Wed Mar  2 11:04:31 2022
> @@ -1,15 +1,15 @@
>  svn, version 1.9.0-dev (under development)
>     compiled Feb 26 2014, 15:15:42 on x86_64-unknown-openbsd5.5
>
> -Copyright (C) 2014 The Apache Software Foundation.
> +Copyright (C) 2012 The Apache Software Foundation.
>  This software consists of contributions made by many people;
>  see the NOTICE file for more information.
>  Subversion is open source software, see http://subversion.apache.org/
>
>  Supported working copy (WC) formats:
>
> -* compatible with Subversion v1.8 to v1.15 (WC format 31)
> -* compatible with Subversion v1.15 (WC format 32)
> +* WC format 31, compatible with Subversion v1.8 and newer
> +* WC format 32, compatible with Subversion v1.15 and newer
>
>  The following repository access (RA) modules are available:
>

Should the following lines also be removed from
subversion/tests/cmdline/getopt_tests.py (line numbers as of r1898187)? It
seems this was in the output previously but was remove a few revisions ago
so I dont think it has to be in the regex

103                  # In svn --version, the supported WC versions vary.
104                  (re.compile(r'^Supported working copy (WC)
version.*$'),
105                   'Supported working copy (WC) versions: from X.Y to
X.Y')

Kind regards
Daniel Sahlberg

(This was not strictly caused by this commit but I couldnt find the
original mail right now)

>

Re: svn commit: r1898524 - in /subversion/trunk/subversion: svn/help-cmd.c tests/cmdline/getopt_tests_data/svn--version--verbose_stdout tests/cmdline/getopt_tests_data/svn--version_stdout

[Julian Foad <ju...@apache.org>]

Julian Foad wrote:
> Daniel Sahlberg wrote:
>> Should the following lines also be removed [...]
> Oh yes. Thank you. Please do if you have a moment, otherwise I'll get
> to it some time this week.

I got to it now. r1898535.

I note that we might want to replace that with a matcher for variations
of the new style, but I saw there didn't seem to be a trivial way to do
so at the moment, and it can wait, so I didn't.

Thank you very much for reviewing these commits. Please keep it coming!

- Julian

Re: svn commit: r1898524 - in /subversion/trunk/subversion: svn/help-cmd.c tests/cmdline/getopt_tests_data/svn--version--verbose_stdout tests/cmdline/getopt_tests_data/svn--version_stdout

[Julian Foad <ju...@apache.org>]

Daniel Sahlberg wrote:
>Should the following lines also be removed [...]
Oh yes. Thank you. Please do if you have a moment, otherwise I'll get to it some time this week.
- Julian