You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:50:11 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new issue #583: change all quotes to smart quotes within error messages

Jimexist opened a new issue #583:
URL: https://github.com/apache/arrow-datafusion/issues/583


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   so far some of the test messages require escaping either single `'` or double `"` quotes. this is error prone and and sometimes introduces confusions.
   
   **Describe the solution you'd like**
   
   we can easily resolve this issue by replacing all current and future usage of quotes into smart quotes `‘` `’` and `“` `”`
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist commented on issue #583: change all quotes to smart quotes within error messages

Posted by GitBox <gi...@apache.org>.

Jimexist commented on issue #583:
URL: https://github.com/apache/arrow-datafusion/issues/583#issuecomment-863883368






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on issue #583: change all quotes to smart quotes within error messages

Posted by GitBox <gi...@apache.org>.

Dandandan commented on issue #583:
URL: https://github.com/apache/arrow-datafusion/issues/583#issuecomment-863897360


   I am not sure changing the error messages for the sake of easier testing makes sense to me.
   
   What about using raw string literals in the tests instead?https://rahul-thakoor.github.io/rust-raw-string-literals/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #583: change all quotes to smart quotes within error messages

Posted by GitBox <gi...@apache.org>.

alamb closed issue #583:
URL: https://github.com/apache/arrow-datafusion/issues/583


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org