You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/03/28 05:14:44 UTC

Review Request 19773: TAJO-529: Fix warnings in tajo-algebra

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19773/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-529
    https://issues.apache.org/jira/browse/TAJO-529


Repository: tajo


Description
-------

Fix warnings in tajo-algebra.


Diffs
-----

  tajo-algebra/src/main/java/org/apache/tajo/algebra/CaseWhenPredicate.java 695a7f1 
  tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java 42dcc68 
  tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java ecf92dc 
  tajo-algebra/src/main/java/org/apache/tajo/algebra/TablePrimarySubQuery.java 2af90b6 

Diff: https://reviews.apache.org/r/19773/diff/


Testing
-------

mvn clean install


Thanks,

Jung JaeHwa

Re: Review Request 19773: TAJO-529: Fix warnings in tajo-algebra

Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19773/#review39023
-----------------------------------------------------------

Ship it!


+1 
Looks great for me.  I've verified 'mvn test findbugs:findbugs'.

- Jinho Kim


On March 28, 2014, 4:14 a.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19773/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 4:14 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-529
>     https://issues.apache.org/jira/browse/TAJO-529
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Fix warnings in tajo-algebra.
> 
> 
> Diffs
> -----
> 
>   tajo-algebra/src/main/java/org/apache/tajo/algebra/CaseWhenPredicate.java 695a7f1 
>   tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java 42dcc68 
>   tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java ecf92dc 
>   tajo-algebra/src/main/java/org/apache/tajo/algebra/TablePrimarySubQuery.java 2af90b6 
> 
> Diff: https://reviews.apache.org/r/19773/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>