You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/01/09 08:03:59 UTC
Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the dependeny patches begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs
-----
src/tests/containerizer/mesos_containerizer_tests.cpp 039f197ece893fdf95c25fe60bb827fa2d7a3cbf
Diff: https://reviews.apache.org/r/55335/diff/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
> On Sept. 26, 2017, 1:23 a.m., Gilbert Song wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp
> > Line 714 (original), 714-720 (patched)
> > <https://reviews.apache.org/r/55335/diff/4/?file=1786808#file1786808line714>
> >
> > will it look cleaner if use `createTask()` helper?
I created a local helper function. All `createTask()` helpers requires some `resources` to work which is not really applicable right now.
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review186191
-----------------------------------------------------------
On Sept. 26, 2017, 8:14 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 8:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
>
>
> Diff: https://reviews.apache.org/r/55335/diff/6/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
> On Sept. 25, 2017, 6:23 p.m., Gilbert Song wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp
> > Line 714 (original), 714-720 (patched)
> > <https://reviews.apache.org/r/55335/diff/4/?file=1786808#file1786808line714>
> >
> > will it look cleaner if use `createTask()` helper?
>
> Zhitao Li wrote:
> I created a local helper function. All `createTask()` helpers requires some `resources` to work which is not really applicable right now.
we can leverage it by using zero resources.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review186191
-----------------------------------------------------------
On Sept. 26, 2017, 1:14 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 1:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
>
>
> Diff: https://reviews.apache.org/r/55335/diff/6/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review186191
-----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp
Line 714 (original), 714-720 (patched)
<https://reviews.apache.org/r/55335/#comment262651>
will it look cleaner if use `createTask()` helper?
- Gilbert Song
On Aug. 1, 2017, 10:10 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 10:10 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp 1fc56c4a8ca95bb47af968ad72dfef69455e7d46
>
>
> Diff: https://reviews.apache.org/r/55335/diff/4/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review189345
-----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 103-119 (patched)
<https://reviews.apache.org/r/55335/#comment266364>
neither introduce a helper here nor a new helper in test/mesos.hpp, let's call createTask() and pass in an empty resource.
- Gilbert Song
On Sept. 26, 2017, 1:14 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 1:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
>
>
> Diff: https://reviews.apache.org/r/55335/diff/6/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review190225
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1091-1092 (original), 1096-1105 (patched)
<https://reviews.apache.org/r/55335/#comment267524>
do you miss these?
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1180-1186 (patched)
<https://reviews.apache.org/r/55335/#comment267525>
ditto.
- Gilbert Song
On Oct. 27, 2017, 11:01 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 11:01 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
>
>
> Diff: https://reviews.apache.org/r/55335/diff/7/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review191417
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Nov. 17, 2017, 8:52 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2017, 8:52 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
>
>
> Diff: https://reviews.apache.org/r/55335/diff/9/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Nov. 17, 2017, 4:52 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
Diff: https://reviews.apache.org/r/55335/diff/9/
Changes: https://reviews.apache.org/r/55335/diff/8-9/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review191280
-----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 103-121 (patched)
<https://reviews.apache.org/r/55335/#comment269042>
why change it back? a mistake?
- Gilbert Song
On Nov. 10, 2017, 11:31 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp ef424150183c782551a3019afcd4b9d1eb94b863
>
>
> Diff: https://reviews.apache.org/r/55335/diff/8/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Nov. 10, 2017, 7:31 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp ef424150183c782551a3019afcd4b9d1eb94b863
Diff: https://reviews.apache.org/r/55335/diff/8/
Changes: https://reviews.apache.org/r/55335/diff/7-8/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Oct. 27, 2017, 6:01 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Reuse `createTask`.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
Diff: https://reviews.apache.org/r/55335/diff/7/
Changes: https://reviews.apache.org/r/55335/diff/6-7/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 8:14 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Fix scope of the common function.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
Diff: https://reviews.apache.org/r/55335/diff/6/
Changes: https://reviews.apache.org/r/55335/diff/5-6/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 6:13 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Rebase and create helper function to address duplicate.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
Diff: https://reviews.apache.org/r/55335/diff/5/
Changes: https://reviews.apache.org/r/55335/diff/4-5/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Aug. 1, 2017, 5:10 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp 1fc56c4a8ca95bb47af968ad72dfef69455e7d46
Diff: https://reviews.apache.org/r/55335/diff/4/
Changes: https://reviews.apache.org/r/55335/diff/3-4/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated May 31, 2017, 5:57 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp d3a2bd7a9a91fe5c2c21066b1633289f36b6c8c5
Diff: https://reviews.apache.org/r/55335/diff/3/
Changes: https://reviews.apache.org/r/55335/diff/2-3/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 9:14 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894
Repository: mesos
Description (updated)
-------
These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.
This patch backfills these fields to make these tests pass.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp 039f197ece893fdf95c25fe60bb827fa2d7a3cbf
Diff: https://reviews.apache.org/r/55335/diff/
Testing
-------
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
Re: Review Request 55335: Backfilled required fields in TaskInfo in
MesosContainerizer* tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review160885
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55334, 55335]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 9, 2017, 8:03 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 8:03 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the dependeny patches begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
>
> This patch backfills these fields to make these tests pass.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp 039f197ece893fdf95c25fe60bb827fa2d7a3cbf
>
> Diff: https://reviews.apache.org/r/55335/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="MesosContainerizer*" make check
>
>
> Thanks,
>
> Zhitao Li
>
>