You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 12:37:46 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #20962: Support generating SQL script for upgrades

potiuk commented on a change in pull request #20962:
URL: https://github.com/apache/airflow/pull/20962#discussion_r803629659



##########
File path: airflow/utils/db.py
##########
@@ -68,6 +69,17 @@
 
 log = logging.getLogger(__name__)
 
+REVISION_HEADS_MAP = {
+    "2.0.0": "e959f08ac86c",
+    "2.0.1": "82b7c48c147f",
+    "2.0.2": "2e42bb497a22",
+    "2.1.0": "a13f7613ad25",
+    "2.1.3": "97cdd93827b8",
+    "2.1.4": "ccde3e26fe78",
+    "2.2.0": "7b2661a43ba3",

Review comment:
       I think we should add all versions. It's very easy to add another command which will filter out the versions that have the same migration head as the previous one if you want "miigration versions only".
   
   And It also gives a great opportunity to print a "happy" message to the users when they run "get me the script to migrate from "2.2.1 to 2.2.2":
   
   ```
   # Hey this is your migration script from 2.2.1, to 2.2.2, but guess what? 
   #
   # There is no migration needed as the database has not changed between those versions. You are done.
   #
   #  /\_/\
   # (='_' )
   # (, (") (")
   #
   ```
   
   
   
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org