[GitHub] [spark] PavithraRamachandran commented on a change in pull request #28931: [SPARK-32103][YARN] Handle IPv6 host/port split in YarnRMClient

[GitBox <gi...@apache.org>]

PavithraRamachandran commented on a change in pull request #28931:
URL: https://github.com/apache/spark/pull/28931#discussion_r448274758



##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClient.scala
##########
@@ -107,7 +107,7 @@ private[spark] class YarnRMClient extends Logging {
     // so not all stable releases have it.
     val prefix = WebAppUtils.getHttpSchemePrefix(conf)
     val proxies = WebAppUtils.getProxyHostsAndPortsForAmFilter(conf)
-    val hosts = proxies.asScala.map(_.split(":").head)
+    val hosts = proxies.asScala.map(proxy => proxy.splitAt(proxy.lastIndexOf(":"))._1)

Review comment:
       I have identified few more places where IPV6 is not handled, i shall update my PR soon




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org