You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/20 15:26:19 UTC

[GitHub] [superset] villebro commented on a change in pull request #14737: fix(explore): DndColumnSelect not handling controls with "multi: false"

villebro commented on a change in pull request #14737:
URL: https://github.com/apache/superset/pull/14737#discussion_r636212284



##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
##########
@@ -77,6 +78,7 @@ export const DndColumnSelect = (props: LabelProps) => {
       canDrop={canDrop}
       valuesRenderer={valuesRenderer}
       accept={DndItemType.Column}
+      displayGhostButton={multi || optionSelector.values.length === 0}

Review comment:
       Bycatch: could we add singular/plural support while we're at it? `ghostButtonText={tn('Drop column', 'Drop columns', multi ? 2 : 1)}`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org