You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/04/09 23:42:37 UTC
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/377
Beautify tooltip bug fix
Fixes a small bug where the tooltip for the Beautify button on the
Edit Index page sometimes doesn't disappear after clicking it.
Also moved the tooltip to the right to prevent overlapping, reduced
the button size a little (it was larger than the main buttons on
the page) and removed a wayward semicolon.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton hide-beautify-tooltip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit b1787f966b922ee4a3a8f632b9b53518fce34c2d
Author: Ben Keen <be...@gmail.com>
Date: 2015-04-09T21:41:09Z
Beautify tooltip bug fix
Fixes a small bug where the tooltip for the Beautify button on the
Edit Index page sometimes doesn't disappear after clicking it.
Also moved the tooltip to the right to prevent overlapping, reduced
the button size a little (it was larger than the main buttons on
the page) and removed a wayward semicolon.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/377#issuecomment-92282464
not in this scope, but i think presenting the button always might be a good idea and helps also when creating a completely new view where i copy&paste stuff
back to the issue: +1 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/377#issuecomment-92391844
That might not be a bad idea. My only concern is when there's nothing to beautify and nothing happens when the user clicks it. Wonder if we could detect that scenario and disable the button... but yeah, another ticket for that. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/377#issuecomment-91597823
Hey @robertkowalski. Yeah, I noticed that too, but on reflection I think it's probably working as it should. It only shows the button if on page load the code is a single line, not when you edit it on the fly. The reason I think that's probably the best behaviour is that when editing the JS content, they may reduce it to a single line (e.g. deleting all lines but the first when re-writing the function). Having the button appear at that point would be a bit weird.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/377#issuecomment-92457397
Merged as 7d0d2dc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Beautify tooltip bug fix
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/377#issuecomment-91513873
code looks good but i can't get the button displayed: https://cloudup.com/cy8qL_nN-EN
am i doing something wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---