You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by nickpan47 <gi...@git.apache.org> on 2018/08/25 00:16:14 UTC

[GitHub] samza pull request #617: SAMZA-1826: Fix unit test failure in table tests

GitHub user nickpan47 opened a pull request:

    https://github.com/apache/samza/pull/617

    SAMZA-1826: Fix unit test failure in table tests

    The way that we verify the join counts in PageViewToProfileJoinFunction across multiple table tests (i.e. TestLocalTable, TestRemoteTable, TestLocalTableWithSideInputs) creates some conflicts in the static counter map and triggers test failure in certain sequence of ordering of tests. Fixing it by requiring explicit name of the join functions in tests and register / verify by unique op names.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickpan47/samza SAMZA-1826

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/617.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #617
    
----
commit 566f13c5cdea8ef0ba317bb9d6456dbc6b8799e8
Author: Yi Pan (Data Infrastructure) <ni...@...>
Date:   2018-08-24T23:27:45Z

    SAMZA-1826: Fix unit test failure in table tests

----


---

[GitHub] samza pull request #617: SAMZA-1826: Fix unit test failure in table tests

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/617


---