You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/02 09:09:07 UTC
[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP opened a new pull request, #1247: mkfats make g_bootcodeblob const to save on static ram usage
PetervdPerk-NXP opened a new pull request, #1247:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1247
## Summary
g_bootcodeblob was allocated in RAM, to be able to patch the offset logic.
This patch makes g_bootcodeblob a constant and patches the offset afterwards to save on ram usage
## Impact
Saves 132 bytes on static ram usage.
## Testing
Tested on MR-CANHUBK3 formatting SD cards as FAT16/FAT32 and checking partition table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1247: mkfats make g_bootcodeblob const to save on .data section usage
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1247:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1247: mkfats make g_bootcodeblob const to save on static ram usage
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1247:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1247#issuecomment-1202227470
The PR description states that "Saves 132 bytes on static ram usage.", but that is only in case of executable flash. I would rework PR description to state that it saves 132 bytes of data segment, but not RAM :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org