You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2010/01/12 03:03:01 UTC
[jira] Commented: (HDFS-775) FSDataset calls getCapacity() twice
-bug?
[ https://issues.apache.org/jira/browse/HDFS-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799006#action_12799006 ]
Hudson commented on HDFS-775:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/])
> FSDataset calls getCapacity() twice -bug?
> -----------------------------------------
>
> Key: HDFS-775
> URL: https://issues.apache.org/jira/browse/HDFS-775
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-775-1.patch, HDFS-775-2.patch
>
>
> I'm not sure this is a bug or "as intended", but I thought I'd mention it.
> FSDataset.getCapacity() calls DF.getCapacity() twice, when evaluating its capacity. Although there is caching to stop the shell being exec'd twice in a row, there is a risk that the first call doesn't run the shell, and the second does -so the value changes during the method.
> If that is not intended, it is better to cache the first value for the whole method
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.