You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/09/21 12:43:25 UTC
Re: Review Request 72887: Tied the 1st hierarchical allocator process
to a process ID "allocator".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/
-----------------------------------------------------------
(Updated Sept. 21, 2020, 2:43 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Resorted to tying only the first process to `"allocator"`.
Summary (updated)
-----------------
Tied the 1st hierarchical allocator process to a process ID "allocator".
Bugs: MESOS-10177
https://issues.apache.org/jira/browse/MESOS-10177
Repository: mesos
Description (updated)
-------
The instances of `HierarchicalAllocatorProcess` launched in the same
instance of libprocess after that will be assigned IDs like
"allocator(2)", "allocator(3)" and so on.
This allows the user to specify a fixed URL like
`https://localhost:5050/allocator/offer_constraints_debug` when querying
HTTP endpoints of an allocator in the mesos-master program instead of
looking up the allocator UPID and using that to compose an URL (like
`https://localhost:5050/hierarchical_allocator(1)/...`)
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 225de160772fe689e07877c895800eb711f211b5
Diff: https://reviews.apache.org/r/72887/diff/2/
Changes: https://reviews.apache.org/r/72887/diff/1-2/
Testing
-------
`make check` on several platforms + tested the debug endpoint manually
Thanks,
Andrei Sekretenko
Re: Review Request 72887: Tied the 1st hierarchical allocator process
to a process ID "allocator".
Posted by Benjamin Mahler <bm...@apache.org>.
> On Sept. 22, 2020, 5:33 a.m., Benjamin Mahler wrote:
> >
Commit description still has "hierarchical_allocator"?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/#review221919
-----------------------------------------------------------
On Sept. 21, 2020, 12:43 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72887/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 12:43 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The instances of `HierarchicalAllocatorProcess` launched in the same
> instance of libprocess after that will be assigned IDs like
> "allocator(2)", "allocator(3)" and so on.
>
> This allows the user to specify a fixed URL like
> `https://localhost:5050/allocator/offer_constraints_debug` when querying
> HTTP endpoints of an allocator in the mesos-master program instead of
> looking up the allocator UPID and using that to compose an URL (like
> `https://localhost:5050/hierarchical_allocator(1)/...`)
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 225de160772fe689e07877c895800eb711f211b5
>
>
> Diff: https://reviews.apache.org/r/72887/diff/2/
>
>
> Testing
> -------
>
> `make check` on several platforms + tested the debug endpoint manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72887: Tied the 1st hierarchical allocator process
to a process ID "allocator".
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/#review221919
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp
Line 976 (original), 978-979 (patched)
<https://reviews.apache.org/r/72887/#comment310970>
Don't need to move this if we want to minimize the diff?
- Benjamin Mahler
On Sept. 21, 2020, 12:43 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72887/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 12:43 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The instances of `HierarchicalAllocatorProcess` launched in the same
> instance of libprocess after that will be assigned IDs like
> "allocator(2)", "allocator(3)" and so on.
>
> This allows the user to specify a fixed URL like
> `https://localhost:5050/allocator/offer_constraints_debug` when querying
> HTTP endpoints of an allocator in the mesos-master program instead of
> looking up the allocator UPID and using that to compose an URL (like
> `https://localhost:5050/hierarchical_allocator(1)/...`)
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 225de160772fe689e07877c895800eb711f211b5
>
>
> Diff: https://reviews.apache.org/r/72887/diff/2/
>
>
> Testing
> -------
>
> `make check` on several platforms + tested the debug endpoint manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72887: Tied the 1st hierarchical allocator process
to a process ID "allocator".
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/#review221917
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72885, 72886, 72851, 72887]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Sept. 21, 2020, 12:43 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72887/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 12:43 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The instances of `HierarchicalAllocatorProcess` launched in the same
> instance of libprocess after that will be assigned IDs like
> "allocator(2)", "allocator(3)" and so on.
>
> This allows the user to specify a fixed URL like
> `https://localhost:5050/allocator/offer_constraints_debug` when querying
> HTTP endpoints of an allocator in the mesos-master program instead of
> looking up the allocator UPID and using that to compose an URL (like
> `https://localhost:5050/hierarchical_allocator(1)/...`)
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 225de160772fe689e07877c895800eb711f211b5
>
>
> Diff: https://reviews.apache.org/r/72887/diff/2/
>
>
> Testing
> -------
>
> `make check` on several platforms + tested the debug endpoint manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72887: Tied the 1st hierarchical allocator process
to a process ID "allocator".
Posted by Andrei Sekretenko <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/
-----------------------------------------------------------
(Updated Sept. 22, 2020, 12:23 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Reworded the commit description, removed stray diff.
Bugs: MESOS-10177
https://issues.apache.org/jira/browse/MESOS-10177
Repository: mesos
Description (updated)
-------
The instances of `HierarchicalAllocatorProcess` launched in the same
instance of libprocess after that will be assigned IDs like
"allocator(2)", "allocator(3)" and so on.
Previously, to query an HTTP endpoint exposed by the allocator,
the user had to figure out the allocator process id and use it to build
the URL (like "https://localhost:5050/hierarchical_allocator(1)/...");
now, the allocator debugging endpoints are accessible via fixed URLs
like "https://localhost:5050/allocator/offer_constraints_debug".
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 63444de857851a267288a530fe868804b7ead2ab
Diff: https://reviews.apache.org/r/72887/diff/3/
Changes: https://reviews.apache.org/r/72887/diff/2-3/
Testing
-------
`make check` on several platforms + tested the debug endpoint manually
Thanks,
Andrei Sekretenko