[GitHub] [incubator-kvrocks] git-hulk commented on pull request #797: Add TLS support for kvrocks connections

[GitBox <gi...@apache.org>]

git-hulk commented on PR #797:
URL: https://github.com/apache/incubator-kvrocks/pull/797#issuecomment-1234376300

   @PragmaTwice I didn't find out the reason but I manually test the tls on macOS and it works normally. Another piece of information is Redis also didn't enable tls test cases on macOS, can see the [redis daily ci](https://github.com/redis/redis/blob/unstable/.github/workflows/daily.yml). I guess maybe there's something wrong with `tcl-tls` since I failed to run tls test cases on my mac.
   
   ```
   ❯ ./runtest --single unit/tls --single unit/info
   Cleanup: may take some time... OK
   Starting test server at port 21079
   [ready]: 77784
   Testing unit/tls
   [ready]: 77785
   Testing unit/info
   [ready]: 77786
   [ready]: 77783
   [ready]: 77787
   [ready]: 77788
   [ready]: 77790
   [ready]: 77789
   [ready]: 77791
   [ready]: 77792
   [ready]: 77793
   [ready]: 77795
   [ready]: 77798
   [ready]: 77796
   [ready]: 77794
   [ready]: 77797
   --- LOG CONTENT ---
   --- LOG CONTENT ---
   [err]: Can't start the Redis server
   CONFIGURATION:always-show-logo yes
   notify-keyspace-events KEA
   daemonize no
   ```
   
   So I think we can disable the tls test cases on mac as well. @ShooterIT @PragmaTwice can correct me if I was wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org