You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/01/20 07:36:45 UTC
[GitHub] [openwhisk-runtime-go] jiangpengcheng opened a new pull request #137: Pass system env to user's action
jiangpengcheng opened a new pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-823346684
> sorry for the late response
>
> our use case is that some of our users executed command(like `python3 --version`) in a python3 action, but they got a `python3 command not found` error, which looks strange for a python3 runtime environment, so I tried to pass some system env to runtime images
Actually, this is interesting... in that there may be a standard means to add runtime-specific env. vars (declared in some way by each runtime) that are acknowledged by the container factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-763656924
> It would be great if you leave some description and ramification of this change.
+1. What's the reason for this change? Also this is different from other runtimes, I think. The environment is carefully constructed in the proxies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] jiangpengcheng commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
jiangpengcheng commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-822935918
sorry for the late response
our use case is that some of our users executed command(like `python3 --version`) in a python3 action, but they got a `python3 command not found` error, which looks strange for a python3 runtime environment, so I tried to pass some system env to runtime images
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-818145654
Also this can leave security holes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] jiangpengcheng closed pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
jiangpengcheng closed pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] jiangpengcheng commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
jiangpengcheng commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-822936144
I will close this as it does introduce some security holes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] style95 commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
style95 commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-763450268
It would be great if you leave some description and ramification of this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on pull request #137: Pass system env to user's action
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #137:
URL: https://github.com/apache/openwhisk-runtime-go/pull/137#issuecomment-822538842
Same concerns as expressed by Rodric and Michele... we should not expose general OS env. vars. only specific variables are made available. Chetan provided an answer on how to pass extra args to the runtime container as a reply to this question:
https://github.com/apache/openwhisk/issues/4308
I too am curious as to the problem/use case you are trying to solve/accomplish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org