You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/07/26 05:20:22 UTC

[GitHub] [phoenix] shahrs87 opened a new pull request, #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

shahrs87 opened a new pull request, #1472:
URL: https://github.com/apache/phoenix/pull/1472

   …hich doesn't exist in hbase-2.4 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] shahrs87 commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
shahrs87 commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1196044244

   All the tests succeeded in the latest run. The asf license warning is not related to my patch.
   Cc @virajjasani 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani merged pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
virajjasani merged PR #1472:
URL: https://github.com/apache/phoenix/pull/1472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
virajjasani commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1196073320

   Thank you @shahrs87 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
virajjasani commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1195780295

   Build in-progress: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1472/3/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
virajjasani commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1195762764

   And we can put this method:
   ```
       @Override
       public Optional getRegionObserver() {
           return Optional.of(this);
       }
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] shahrs87 commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
shahrs87 commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1195664308

   The following tests are failing in jenkins build. It is failing even in master branch without my patch. It is failing to bring up datanode. Created [PHOENIX-6757](https://issues.apache.org/jira/browse/PHOENIX-6757) to track these failures.
   ```
   [ERROR] Failures: 
   [ERROR]   IndexToolForNonTxGlobalIndexIT.testSecondaryGlobalIndexFailure:385 expected:<-1> but was:<0>
   [ERROR]   IndexToolForNonTxGlobalIndexIT.testSecondaryGlobalIndexFailure:385 expected:<-1> but was:<0>
   [ERROR] Errors: 
   [ERROR]   BackwardCompatibilityIT.testViewIndexIdCreatedWithOldClient:428 » SQL ERROR 20...
   [ERROR]   ViewIndexIdRetrieveIT.testMixedCase:145 » SQL ERROR 201 (22000): Illegal data....
   [ERROR]   ViewIndexIdRetrieveIT.testSelectViewIndexIdAsShort:80->testSelectViewIndexId:103 » SQL
   [INFO] 
   [ERROR] Tests run: 1610, Failures: 2, Errors: 3, Skipped: 65
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani commented on pull request #1472: PHOENIX-6755 SystemCatalogRegionObserver extends BaseRegionObserver w…

Posted by GitBox <gi...@apache.org>.
virajjasani commented on PR #1472:
URL: https://github.com/apache/phoenix/pull/1472#issuecomment-1195758840

   Retriggered the tests on the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org