You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Everett Toews <no...@github.com> on 2014/04/16 22:08:54 UTC
[jclouds-site] More generic logging example code (#79)
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-site generic-logging
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/79
-- Commit Summary --
* More generic logging example code
-- File Changes --
M reference/logging.md (15)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/79.patch
https://github.com/jclouds/jclouds-site/pull/79.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79
Re: [jclouds-site] More generic logging example code (#79)
Posted by Everett Toews <no...@github.com>.
Merged and deployed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40713888
Re: [jclouds-site] More generic logging example code (#79)
Posted by Everett Toews <no...@github.com>.
> @@ -114,14 +114,21 @@ You'll also need a logback.xml configuration file on your classpath. Here's an e
>
> ## <a id="enable"></a>Enable Logging
>
> -Below is some example code of how to enable your code to use SLF4J. The SLF4JLoggingModule needs to be passed in to the ContextBuilder of whatever context you're building.
> +Below is some example code of how to enable your code to use SLF4J. The `SLF4JLoggingModule` in the variable `modules` needs to be passed into the `ContextBuilder.modules(Iterable)` method of whatever `Context` or `Api` you're building.
I've updated the description.
The Javadoc for ContextBuilder.modules doesn't provide anymore information than what's here.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79/files#r11707627
Re: [jclouds-site] More generic logging example code (#79)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #254](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/254/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40713303
Re: [jclouds-site] More generic logging example code (#79)
Posted by Everett Toews <no...@github.com>.
> @@ -114,14 +114,21 @@ You'll also need a logback.xml configuration file on your classpath. Here's an e
>
> ## <a id="enable"></a>Enable Logging
>
> -Below is some example code of how to enable your code to use SLF4J. The SLF4JLoggingModule needs to be passed in to the ContextBuilder of whatever context you're building.
> +Below is some example code of how to enable your code to use SLF4J. The `SLF4JLoggingModule` needs to be added to the `modules` Set that are passed into the `ContextBuilder.modules(Iterable)` method of whatever Context or Api you're building.
Fixed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79/files#r11731335
Re: [jclouds-site] More generic logging example code (#79)
Posted by jclouds-commentator <no...@github.com>.
Go to http://5fd6fcdd2401a4209bd9-585f196bc4aa09b43320dcea5a0fe438.r16.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40653392
Re: [jclouds-site] More generic logging example code (#79)
Posted by Everett Toews <no...@github.com>.
Closed #79.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79
Re: [jclouds-site] More generic logging example code (#79)
Posted by Andrew Phillips <no...@github.com>.
+1 - thanks, @everett-toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40717919
Re: [jclouds-site] More generic logging example code (#79)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #251](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/251/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40645969
Re: [jclouds-site] More generic logging example code (#79)
Posted by Andrew Phillips <no...@github.com>.
> @@ -114,14 +114,21 @@ You'll also need a logback.xml configuration file on your classpath. Here's an e
>
> ## <a id="enable"></a>Enable Logging
>
> -Below is some example code of how to enable your code to use SLF4J. The SLF4JLoggingModule needs to be passed in to the ContextBuilder of whatever context you're building.
> +Below is some example code of how to enable your code to use SLF4J. The `SLF4JLoggingModule` in the variable `modules` needs to be passed into the `ContextBuilder.modules(Iterable)` method of whatever `Context` or `Api` you're building.
"The SLF.. needs to be added to the modules that are passed into the `ContextBuilder.modules(Iterable)` method..."
Perhaps make the "ContextBuilder.modules" bit a link to the Javadoc?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79/files#r11705915
Re: [jclouds-site] More generic logging example code (#79)
Posted by Andrew Phillips <no...@github.com>.
> @@ -114,14 +114,21 @@ You'll also need a logback.xml configuration file on your classpath. Here's an e
>
> ## <a id="enable"></a>Enable Logging
>
> -Below is some example code of how to enable your code to use SLF4J. The SLF4JLoggingModule needs to be passed in to the ContextBuilder of whatever context you're building.
> +Below is some example code of how to enable your code to use SLF4J. The `SLF4JLoggingModule` needs to be added to the `modules` Set that are passed into the `ContextBuilder.modules(Iterable)` method of whatever Context or Api you're building.
Now says "the modules Set that are passed into" when it's actually an `Iterable`? How about
* "the modules that are passed into" (no formatting on "modules") or
* "the `modules` collection that is passed into"
?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79/files#r11712571
Re: [jclouds-site] More generic logging example code (#79)
Posted by jclouds-commentator <no...@github.com>.
Go to http://75854f83a688a542d91a-044f721232b599b2e7c0dda317c1e105.r85.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40646165
Re: [jclouds-site] More generic logging example code (#79)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #253](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/253/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40653182