You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Felipe Rodrigues (Jira)" <ji...@apache.org> on 2019/10/27 15:46:00 UTC
[jira] [Commented] (AIRFLOW-5791) Documentation on Google Auth has
a flaw on the domain setting
[ https://issues.apache.org/jira/browse/AIRFLOW-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960630#comment-16960630 ]
Felipe Rodrigues commented on AIRFLOW-5791:
-------------------------------------------
Turns out it was [fixed|https://github.com/fbidu/airflow/commit/44df8a1d47a7d3e3d4b52b7a8a1d9a37af653ac8] 11 months ago already! I should have seen the current state in the code instead of just checking the released docs.
Sorry about that!
> Documentation on Google Auth has a flaw on the domain setting
> -------------------------------------------------------------
>
> Key: AIRFLOW-5791
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5791
> Project: Apache Airflow
> Issue Type: Bug
> Components: authentication, documentation
> Affects Versions: 1.10.5
> Reporter: Felipe Rodrigues
> Assignee: Felipe Rodrigues
> Priority: Trivial
>
> Hello, all!
> I just ran into an issue while trying to setup Google Auth. After performing all the required steps, I was able to authenticate with Google but airflow kept giving me an error, saying that I wasn't actually logged in.
> It turns out that the docs says that I should set up the allowed domains as
> {{domain = "example1.com,example2.com" }}
> But those double quotes are wrong, it actually needs to be like
> {{domain = example1.com,example2.com}}
> There is a user on StackOverflow that ran into this [same problem|https://stackoverflow.com/q/48297391/2713733]
> I'll issue a PR fixing this detail shortly.
> Thank you all!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)