You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/11 11:54:25 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #1757: libs/libc/stdio: replace double_t to double
GUIDINGLI opened a new pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757
Modify reason:
When build Nuttx SIM, in x86_64 system:
Compile with gcc option '-m64' (default):
sizeof(double_t) = 8
sizeof(double) = 8
Compile with gcc option '-mx32':
sizeof(double_t) = 8
sizeof(double) = 8
Compile with gcc option '-m32':
sizeof(double_t) = 12 // long double
sizeof(double) = 8
When use '-m32', and print sth. like this:
printf("%f\n", (double)3.0);
SIM will print out: nan
This is because sizeof(double_t) is not equal with double.
Resolve:
replace all double_t to double in libs/libc/stdio.
As a user of '-m32', you should know double_t is one type
long double, and len is 12. And you use use '%lf' to print.
like:
printf("%lf\n", (double_t)3.0);
Currently we don't support '%lf'.
Change-Id: I9b9d11853140d5296dd80416c8ed6a260a9d2d9c
Signed-off-by: ligd <li...@xiaomi.com>
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691200381
@v01d is correct. We should just drop the cache with changes made on GitHubs side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691902949
@v01d done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691197222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691298555
@GUIDINGLI Please rebase against master, this should fix the build failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691197222
I've seen this failure before, when downloading source cache. My attempt to handle this is in #1762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691200381
@v01d is correct. We should just drop the cache with changes made on GitHubs side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691200381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691197222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1757: libs/libc/stdio: replace double_t to double
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1757:
URL: https://github.com/apache/incubator-nuttx/pull/1757#issuecomment-691197222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org