Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

[Jacques Le Roux <ja...@les7arts.com>]

I think this will never happen, let's see...

Le 27/05/2020 à 09:16, Jacques Le Roux a écrit :
> I created INFRA-20331 for that
>
> Jacques
>
> Le 23/05/2020 à 11:34, Pierre Smits a écrit :
>> Thanks Jacques, forellen staking care of thuis.
>>
>> Op za 23 mei 2020 11:28 schreef Jacques Le Roux <
>> jacques.le.roux@les7arts.com>:
>>
>>> Actually we have also this information nicely coming to ofbiz-*@
>>> noreply.github.com
>>>
>>> So we don't need the ugly couples (added then removed) at
>>> notifications@ofbiz.apache.org
>>>
>>> If nobody disagree I'll see if Infra can do something about that in a
>>> week...
>>>
>>> Jacques
>>>
>>> Le 20/05/2020 à 20:24, Pierre Smits a écrit :
>>>> It happened to me a few times that a PR didn't pass the quality gates of
>>>> SonarCloud. And it helped me to correct the situation on a next push
>>>>
>>>> RE: BTW is a PR pushable if the SonarCloud tests don't pass?
>>>> SonarCloud tests are done AFTER the PR is created. Then it checks on
>>> every
>>>> commit coming in from where the PR was originated.
>>>>
>>>> Met vriendelijke groet,
>>>>
>>>> Pierre Smits
>>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/>
>>> since
>>>> 2008 (without privileges)
>>>>
>>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
>>>> *Apache Directory <https://directory.apache.org>, PMC Member*
>>>> Apache Incubator <https://incubator.apache.org>, committer
>>>> Apache Steve <https://steve.apache.org>, committer
>>>>
>>>>
>>>> On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>>> For me both are useless, I have never seen a SonarCloud Quality Gate not
>>>>> passing and this information is visible on the PR before pushing it
>>>>>
>>>>> BTW is a PR pushable if the SonarCloud tests don't  pass?
>>>>>
>>>>> I could filter them, but by experience I tend to privilege cutting at
>>>>> root. Because maintainer email filters is not my cup of tea.
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 20/05/2020 à 19:54, Pawan Verma a écrit :
>>>>>> Hi Pierre,
>>>>>>
>>>>>> For me, this one is good --> Kudos, SonarCloud Quality Gate passed!
>>>>>>
>>>>>> This one seems to be useless --> sonarcloud[bot] removed a comment on
>>>>> pull
>>>>>> request
>