[kudu-CR] [spark] Add a test for sink based writing

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14603 )

Change subject: [spark] Add a test for sink based writing
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:

http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@349
PS1, Line 349:       .format("kudu")
             :       .option("kudu.master", harness.getMasterAddressesAsString)
             :       .option("kudu.table", tableName)
             :       .mode(SaveMode.Append)
             :       .save()
nit: could you add a comment explaining why that we don't need to supply "kudu.operation" because the default operation is UPSERT for the sink?


http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@365
PS1, Line 365:       .mode(SaveMode.Append)
Do the other save modes work? If they do, maybe test them too?



-- 
To view, visit http://gerrit.cloudera.org:8080/14603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f28be80ad21b0783d8a0889ad7b1847601442b
Gerrit-Change-Number: 14603
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Nov 2019 21:38:40 +0000
Gerrit-HasComments: Yes