You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Osdel (via GitHub)" <gi...@apache.org> on 2023/07/16 19:24:08 UTC

[GitHub] [commons-lang] Osdel commented on pull request #786: Lang-1657: Diff Result Type Constraint

Osdel commented on PR #786:
URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637170747

   What happened to this pull request? This change is really needed. Having the `DiffBuilder<T>.append()` constraint on passing a `DiffResult<T>` is not ideal. Ideally you want to recursively call on nested attributes that implement the `Diffable` interface. I am not getting build errors but a lot of `Uncheck` warnings  which are unpleasant. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org