You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Gagandeep singh <ga...@gmail.com> on 2010/10/26 15:27:57 UTC

Issue 2646041: Setting return-original-content-on-error for accel container

Reviewers: *dev@shindig.apache.org*

Description:

Setting returnOriginalContentOnError true for accel container so that
ProxyHandler does not throw exceptions and returns original content.

When using VanillaCajaHtmlParser, we see the following exception on some pages:

org.apache.shindig.gadgets.rewrite.RewritingException: content.getDocument is
null.
Content:

org.apache.shindig.gadgets.rewrite.DomWalker$Rewriter.rewrite(DomWalker.java:162)
org.apache.shindig.gadgets.rewrite.DomWalker$Rewriter.rewrite(DomWalker.java:151)
org.apache.shindig.gadgets.rewrite.DefaultResponseRewriterRegistry.rewriteHttpResponse(DefaultResponseRewriterRegistry.java:55)
org.apache.shindig.gadgets.servlet.ProxyHandler.doFetch(ProxyHandler.java:133)
org.apache.shindig.gadgets.servlet.ProxyBase.fetch(ProxyBase.java:165)
org.apache.shindig.gadgets.servlet.ProxyServlet.doGet(ProxyServlet.java:60)
javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)


Please review this at http://codereview.appspot.com/2646041/

Affected files:
  M
 java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
  A
 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/ProxyUriManagerTest.java

Thanks
Gagan