You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/12 23:37:02 UTC

[GitHub] [trafficserver] shinrich commented on a change in pull request #7818: Reduces an amount of conditional checks at the cache_op

shinrich commented on a change in pull request #7818:
URL: https://github.com/apache/trafficserver/pull/7818#discussion_r631470173



##########
File path: iocore/aio/AIO.cc
##########
@@ -379,18 +379,15 @@ aio_queue_req(AIOCallbackInternal *op, int fromAPI = 0)
 static inline int
 cache_op(AIOCallbackInternal *op)
 {
-  bool read = (op->aiocb.aio_lio_opcode == LIO_READ);
+  typedef ssize_t (*p)(int, void*, size_t, __off_t);
+  p action=(op->aiocb.aio_lio_opcode == LIO_READ)?pread:(p)pwrite;
   for (; op; op = (AIOCallbackInternal *)op->then) {

Review comment:
       Seems reasonable enough.  But why is there a (p) in front of pwrite?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org