[GitHub] [geode] jujoramos opened pull request #4271: GEODE-7110: Add Tomcat Session Integration Tests

["jujoramos (GitHub)" <gi...@apache.org>]

- Fixed minor warnings.
- Added integration tests for Tomcat Session State Module Classes.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4271 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos closed pull request #4271: GEODE-7110: Add Tomcat Session Integration Tests

["jujoramos (GitHub)" <gi...@apache.org>]

[ pull request closed by jujoramos ]

[ Full content available at: https://github.com/apache/geode/pull/4271 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #4271: GEODE-7110: Add Tomcat Session Integration Tests

["jhuynh1 (GitHub)" <gi...@apache.org>]

We usually try not to rely on sleeps and instead try to wait for a condition to occur (and maybe have that time out if the criteria is not met)  Is there a condition we can wait on instead?

[ Full content available at: https://github.com/apache/geode/pull/4271 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on pull request #4271: GEODE-7110: Add Tomcat Session Integration Tests

["jujoramos (GitHub)" <gi...@apache.org>]

Sure, will check whether there's a condition I can wait for (hard to think on one as the test just needs for time to pass...).

[ Full content available at: https://github.com/apache/geode/pull/4271 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org