You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2025/11/17 10:44:54 UTC

(impala) 03/04: IMPALA-14552: (addendum) Fix bad testcase in show-create-table.test

This is an automated email from the ASF dual-hosted git repository.

boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 898e03e9d5dd9aa43494e4ffd93063beebf6885b
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Sat Nov 15 08:36:58 2025 -0800

    IMPALA-14552: (addendum) Fix bad testcase in show-create-table.test
    
    The original IMPALA-14552 patch pass precommit tests before
    IMPALA-12893: (part 2) (275f03f) merged. As consequence, it does not
    catch missing comma in updated show-create-table.test. This patch add
    that missing comma.
    
    Testing:
    Pass metadata/test_show_create_table.py
    
    Change-Id: Ib06e690a81e6b0ca483b3647cc59c73802a0a7b7
    Reviewed-on: http://gerrit.cloudera.org:8080/23673
    Reviewed-by: Riza Suminto <ri...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 .../workloads/functional-query/queries/QueryTest/show-create-table.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test b/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
index e7b1a7119..c47ea1a0a 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
@@ -968,7 +968,7 @@ PARTITIONED BY SPEC (VOID(i), VOID(j))
 STORED AS ICEBERG
 LOCATION '$$location_uri$$'
 TBLPROPERTIES ('external.table.purge'='TRUE', 'write.format.default'='parquet',
-'engine.hive.enabled'='true', 'table_type'='ICEBERG', 'write.parquet.compression-codec'='snappy'
+'engine.hive.enabled'='true', 'table_type'='ICEBERG', 'write.parquet.compression-codec'='snappy',
 'write.delete.mode'='merge-on-read', 'write.update.mode'='merge-on-read',
 'write.merge.mode'='merge-on-read')
 ====