You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 14:19:34 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #11738: ARROW-14169: [R] altrep for factors

jonkeane commented on a change in pull request #11738:
URL: https://github.com/apache/arrow/pull/11738#discussion_r783999870



##########
File path: r/src/altrep.cpp
##########
@@ -23,6 +23,7 @@
 #include <arrow/chunked_array.h>
 #include <arrow/compute/api.h>
 #include <arrow/util/bitmap_reader.h>
+#include <arrow/visitor_inline.h>

Review comment:
       Aaah, this is failing because `visitor_inline.h` was split into a number of separate files in https://github.com/apache/arrow/commit/91e3ac53e2e21736ce6291d73fc37da6fa21259d
   
   These might not all be needed, but this looks like all of the ones that the original was split into:
   
   ```suggestion
   #include <arrow/visitor_array_inline.h>
   #include <arrow/visitor_data_inline.h>
   #include <arrow/visitor_scalar_inline.h>
   #include <arrow/visitor_type_inline.h>
   ```
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org