[GitHub] [solr] gerlowskija commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

[GitBox <gi...@apache.org>]

gerlowskija commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914874464


##########
solr/core/src/test/org/apache/solr/handler/admin/V2ApiMappingTest.java:
##########
@@ -204,11 +204,12 @@ public String getHttpMethod() {
     return queryRequestCaptor.getValue().getParams();
   }
 
-  protected void assertAnnotatedApiExistsFor(String method, String path) {
+  protected AnnotatedApi assertAnnotatedApiExistsFor(String method, String path) {
     final AnnotatedApi api = getAnnotatedApiFor(method, path);
     assertTrue(
         "Expected to find API mapping for [" + method + " " + path + "] but none found!",
         api != null);
+    return api;

Review Comment:
   Tests that call this method can use the returned API for additional, more detailed asserting.
   
   For an example, see [here](https://github.com/apache/solr/pull/932/files#diff-e34dd712e2ac23556653b6da663842732181d039312b0d209376fe0120fb48ecR52)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org