You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jason Golieb <jg...@hortonworks.com> on 2017/12/22 21:41:15 UTC
Review Request 64816: Implement download configuration options and
custom (i.e. local) repo support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64816/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
Bugs: AMBARI-22695
https://issues.apache.org/jira/browse/AMBARI-22695
Repository: ambari
Description
-------
Implement support for downloading mpacks from custom URLs (local repos) and using proxy configuration or Satellite/Spacewalker options.
If the Custom/Local download option is selected, present a screen to the user that allows them to input custom URLs for the mpack locations. This will be presented after the mpack selection step.
If the user selected the Custom/Local download configuration, present a screen where they can provide custom URLs for each product repo within the mpacks for each OS that is selected. This screen is pre-filled with the public repo URLs and the user can change any or all of them to use a custom URL.
Diffs
-----
ambari-web/app/controllers.js 5af0937f9b
ambari-web/app/controllers/installer.js 59571e7f3c
ambari-web/app/controllers/wizard.js c5a07fff8d
ambari-web/app/controllers/wizard/configureDownload_controller.js 08af9603f9
ambari-web/app/controllers/wizard/customMpackRepos_controller.js PRE-CREATION
ambari-web/app/controllers/wizard/customProductRepos_controller.js PRE-CREATION
ambari-web/app/controllers/wizard/downloadProducts_controller.js d12ae11d1f
ambari-web/app/controllers/wizard/selectMpacks_controller.js 7951d155e0
ambari-web/app/controllers/wizard/step0_controller.js 270c7a4b21
ambari-web/app/controllers/wizard/step10_controller.js 6840c1389b
ambari-web/app/controllers/wizard/step1_controller.js c137d96b5d
ambari-web/app/controllers/wizard/step2_controller.js dffc17e76b
ambari-web/app/controllers/wizard/step3_controller.js 36bf05a20e
ambari-web/app/controllers/wizard/step4_controller.js d82bf34df5
ambari-web/app/controllers/wizard/step5_controller.js 3ca4165e68
ambari-web/app/controllers/wizard/step6_controller.js b1941f070f
ambari-web/app/controllers/wizard/step7_controller.js 4b1eacbd8a
ambari-web/app/controllers/wizard/step8_controller.js 3ad65f170c
ambari-web/app/controllers/wizard/step9_controller.js 9f27f654a6
ambari-web/app/controllers/wizard/verifyProducts_controller.js PRE-CREATION
ambari-web/app/controllers/wizard/wizardStep_controller.js PRE-CREATION
ambari-web/app/mappers/stack_mapper.js 415845e6e9
ambari-web/app/messages.js 2efc023cd3
ambari-web/app/mixins/wizard/wizard_menu_view.js 6dd7394bf6
ambari-web/app/models/repository.js c50750feda
ambari-web/app/router.js d0b171477e
ambari-web/app/routes/installer.js 80cf116f04
ambari-web/app/styles/theme/bootstrap-ambari.css 97419c7782
ambari-web/app/styles/wizard.less 4330c6a81b
ambari-web/app/templates/installer.hbs 47e63ccac5
ambari-web/app/templates/wizard/customMpackRepos.hbs PRE-CREATION
ambari-web/app/templates/wizard/customProductRepos.hbs PRE-CREATION
ambari-web/app/templates/wizard/downloadProducts.hbs a42622507f
ambari-web/app/templates/wizard/selectMpacks.hbs d78861e43f
ambari-web/app/templates/wizard/verifyProducts.hbs PRE-CREATION
ambari-web/app/views.js 8810f1328c
ambari-web/app/views/wizard/configureDownload_view.js 71c6527b82
ambari-web/app/views/wizard/customMpackRepos_view.js PRE-CREATION
ambari-web/app/views/wizard/customProductRepos_view.js PRE-CREATION
ambari-web/app/views/wizard/downloadProducts_view.js b70275a9ea
ambari-web/app/views/wizard/verifyProducts_view.js PRE-CREATION
ambari-web/test/controllers/installer_test.js 88289b2a43
ambari-web/test/controllers/wizard/selectMpacks_test.js 13e28ce23b
Diff: https://reviews.apache.org/r/64816/diff/1/
Testing
-------
20297 passing (47s)
125 pending
Note that no new tests were added. These will be done later. Current priority is to make this functional for the 1/1/18 milestone.
Thanks,
Jason Golieb
Re: Review Request 64816: Implement download configuration options and
custom (i.e. local) repo support
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64816/#review194473
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Dec. 22, 2017, 9:41 p.m., Jason Golieb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64816/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 9:41 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-22695
> https://issues.apache.org/jira/browse/AMBARI-22695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Implement support for downloading mpacks from custom URLs (local repos) and using proxy configuration or Satellite/Spacewalker options.
>
> If the Custom/Local download option is selected, present a screen to the user that allows them to input custom URLs for the mpack locations. This will be presented after the mpack selection step.
>
> If the user selected the Custom/Local download configuration, present a screen where they can provide custom URLs for each product repo within the mpacks for each OS that is selected. This screen is pre-filled with the public repo URLs and the user can change any or all of them to use a custom URL.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers.js 5af0937f9b
> ambari-web/app/controllers/installer.js 59571e7f3c
> ambari-web/app/controllers/wizard.js c5a07fff8d
> ambari-web/app/controllers/wizard/configureDownload_controller.js 08af9603f9
> ambari-web/app/controllers/wizard/customMpackRepos_controller.js PRE-CREATION
> ambari-web/app/controllers/wizard/customProductRepos_controller.js PRE-CREATION
> ambari-web/app/controllers/wizard/downloadProducts_controller.js d12ae11d1f
> ambari-web/app/controllers/wizard/selectMpacks_controller.js 7951d155e0
> ambari-web/app/controllers/wizard/step0_controller.js 270c7a4b21
> ambari-web/app/controllers/wizard/step10_controller.js 6840c1389b
> ambari-web/app/controllers/wizard/step1_controller.js c137d96b5d
> ambari-web/app/controllers/wizard/step2_controller.js dffc17e76b
> ambari-web/app/controllers/wizard/step3_controller.js 36bf05a20e
> ambari-web/app/controllers/wizard/step4_controller.js d82bf34df5
> ambari-web/app/controllers/wizard/step5_controller.js 3ca4165e68
> ambari-web/app/controllers/wizard/step6_controller.js b1941f070f
> ambari-web/app/controllers/wizard/step7_controller.js 4b1eacbd8a
> ambari-web/app/controllers/wizard/step8_controller.js 3ad65f170c
> ambari-web/app/controllers/wizard/step9_controller.js 9f27f654a6
> ambari-web/app/controllers/wizard/verifyProducts_controller.js PRE-CREATION
> ambari-web/app/controllers/wizard/wizardStep_controller.js PRE-CREATION
> ambari-web/app/mappers/stack_mapper.js 415845e6e9
> ambari-web/app/messages.js 2efc023cd3
> ambari-web/app/mixins/wizard/wizard_menu_view.js 6dd7394bf6
> ambari-web/app/models/repository.js c50750feda
> ambari-web/app/router.js d0b171477e
> ambari-web/app/routes/installer.js 80cf116f04
> ambari-web/app/styles/theme/bootstrap-ambari.css 97419c7782
> ambari-web/app/styles/wizard.less 4330c6a81b
> ambari-web/app/templates/installer.hbs 47e63ccac5
> ambari-web/app/templates/wizard/customMpackRepos.hbs PRE-CREATION
> ambari-web/app/templates/wizard/customProductRepos.hbs PRE-CREATION
> ambari-web/app/templates/wizard/downloadProducts.hbs a42622507f
> ambari-web/app/templates/wizard/selectMpacks.hbs d78861e43f
> ambari-web/app/templates/wizard/verifyProducts.hbs PRE-CREATION
> ambari-web/app/views.js 8810f1328c
> ambari-web/app/views/wizard/configureDownload_view.js 71c6527b82
> ambari-web/app/views/wizard/customMpackRepos_view.js PRE-CREATION
> ambari-web/app/views/wizard/customProductRepos_view.js PRE-CREATION
> ambari-web/app/views/wizard/downloadProducts_view.js b70275a9ea
> ambari-web/app/views/wizard/verifyProducts_view.js PRE-CREATION
> ambari-web/test/controllers/installer_test.js 88289b2a43
> ambari-web/test/controllers/wizard/selectMpacks_test.js 13e28ce23b
>
>
> Diff: https://reviews.apache.org/r/64816/diff/1/
>
>
> Testing
> -------
>
> 20297 passing (47s)
> 125 pending
>
> Note that no new tests were added. These will be done later. Current priority is to make this functional for the 1/1/18 milestone.
>
>
> Thanks,
>
> Jason Golieb
>
>