You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 16:20:15 UTC

[GitHub] [arrow] pitrou opened a new pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

pitrou opened a new pull request #12708:
URL: https://github.com/apache/arrow/pull/12708


   Fix this compilation error:
   ```
   /home/antoine/arrow/dev/cpp/src/arrow/dataset/file_orc_test.cc:45:27: error: 'ReadAll' is deprecated: Deprecated in 8.0.0. Use ToTable instead. [-Werror,-Wdeprecated-declarations]
       RETURN_NOT_OK(reader->ReadAll(&table));
                             ^
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12708:
URL: https://github.com/apache/arrow/pull/12708#issuecomment-1077933759


   Benchmark runs are scheduled for baseline = ddb663b1724034f64cc53d62bd2d5a4e8fa42954 and contender = 19b75f26d7426ed6b5bddb7fe0843c2634aedb29. 19b75f26d7426ed6b5bddb7fe0843c2634aedb29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a26af5a151f4fe69dcbb7cb5775cbfd...6e71781946a542728c1988d8e810a228/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3a17327ee0474b11a92c9af8fb11d2c4...8657d1dc22d140389359ea70e9b7b40c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/843dcac430034b69a9ccbe123bec88f7...8ec793a3d25544aa92fdf4f2abca8f7f/)
   [Finished :arrow_down:0.55% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/90d211cbe0ea45dfbcc4550992591f64...0ed617e51abc466d99c116f5ce0c449f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12708:
URL: https://github.com/apache/arrow/pull/12708#issuecomment-1077933759


   Benchmark runs are scheduled for baseline = ddb663b1724034f64cc53d62bd2d5a4e8fa42954 and contender = 19b75f26d7426ed6b5bddb7fe0843c2634aedb29. 19b75f26d7426ed6b5bddb7fe0843c2634aedb29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a26af5a151f4fe69dcbb7cb5775cbfd...6e71781946a542728c1988d8e810a228/)
   [Finished :arrow_down:0.34% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3a17327ee0474b11a92c9af8fb11d2c4...8657d1dc22d140389359ea70e9b7b40c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/843dcac430034b69a9ccbe123bec88f7...8ec793a3d25544aa92fdf4f2abca8f7f/)
   [Finished :arrow_down:0.55% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/90d211cbe0ea45dfbcc4550992591f64...0ed617e51abc466d99c116f5ce0c449f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12708:
URL: https://github.com/apache/arrow/pull/12708#issuecomment-1077933759


   Benchmark runs are scheduled for baseline = ddb663b1724034f64cc53d62bd2d5a4e8fa42954 and contender = 19b75f26d7426ed6b5bddb7fe0843c2634aedb29. 19b75f26d7426ed6b5bddb7fe0843c2634aedb29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a26af5a151f4fe69dcbb7cb5775cbfd...6e71781946a542728c1988d8e810a228/)
   [Finished :arrow_down:0.34% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3a17327ee0474b11a92c9af8fb11d2c4...8657d1dc22d140389359ea70e9b7b40c/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/843dcac430034b69a9ccbe123bec88f7...8ec793a3d25544aa92fdf4f2abca8f7f/)
   [Finished :arrow_down:0.55% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/90d211cbe0ea45dfbcc4550992591f64...0ed617e51abc466d99c116f5ce0c449f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12708:
URL: https://github.com/apache/arrow/pull/12708#issuecomment-1077933759


   Benchmark runs are scheduled for baseline = ddb663b1724034f64cc53d62bd2d5a4e8fa42954 and contender = 19b75f26d7426ed6b5bddb7fe0843c2634aedb29. 19b75f26d7426ed6b5bddb7fe0843c2634aedb29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a26af5a151f4fe69dcbb7cb5775cbfd...6e71781946a542728c1988d8e810a228/)
   [Finished :arrow_down:0.34% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3a17327ee0474b11a92c9af8fb11d2c4...8657d1dc22d140389359ea70e9b7b40c/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/843dcac430034b69a9ccbe123bec88f7...8ec793a3d25544aa92fdf4f2abca8f7f/)
   [Finished :arrow_down:0.55% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/90d211cbe0ea45dfbcc4550992591f64...0ed617e51abc466d99c116f5ce0c449f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm closed pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12708:
URL: https://github.com/apache/arrow/pull/12708


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12708: MINOR: [C++] Avoid using deprecated RecordBatchReader::ReadAll

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12708:
URL: https://github.com/apache/arrow/pull/12708#issuecomment-1077933759


   Benchmark runs are scheduled for baseline = ddb663b1724034f64cc53d62bd2d5a4e8fa42954 and contender = 19b75f26d7426ed6b5bddb7fe0843c2634aedb29. 19b75f26d7426ed6b5bddb7fe0843c2634aedb29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a26af5a151f4fe69dcbb7cb5775cbfd...6e71781946a542728c1988d8e810a228/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3a17327ee0474b11a92c9af8fb11d2c4...8657d1dc22d140389359ea70e9b7b40c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/843dcac430034b69a9ccbe123bec88f7...8ec793a3d25544aa92fdf4f2abca8f7f/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/90d211cbe0ea45dfbcc4550992591f64...0ed617e51abc466d99c116f5ce0c449f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org