You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2016/04/11 21:50:45 UTC

Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46047/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15812
    https://issues.apache.org/jira/browse/AMBARI-15812


Repository: ambari


Description
-------

HDFS, Yarn, HBase widgets that show Counter metrics were changed to use "rate" aggregation function for AMS in AMBARI-15385. However, these changes were not done in Upgrade path.

Hence, these widgets will still request counter data as it is instead of as a Rate metric (._rate).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java fc0e6b2 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java cc5a04d 

Diff: https://reviews.apache.org/r/46047/diff/


Testing
-------

UpgradeCatalog tests pass.

Manual testing pending.


Thanks,

Aravindan Vijayan


Re: Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46047/#review128258
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On April 11, 2016, 9:32 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46047/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 9:32 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15812
>     https://issues.apache.org/jira/browse/AMBARI-15812
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS, Yarn, HBase widgets that show Counter metrics were changed to use "rate" aggregation function for AMS in AMBARI-15385. However, these changes were not done in Upgrade path.
> 
> Hence, these widgets will still request counter data as it is instead of as a Rate metric (._rate).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java fc0e6b2 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java cc5a04d 
> 
> Diff: https://reviews.apache.org/r/46047/diff/
> 
> 
> Testing
> -------
> 
> UpgradeCatalog tests pass.
> 
> Manual testing done.
> 
> 11 Apr 2016 20:26:00,333  INFO [main] UpgradeCatalog222:430 - Updating HDFS widget definition.
> 11 Apr 2016 20:26:00,342  INFO [main] UpgradeCatalog222:519 - Updating widget: HDFS Bytes Read
> 11 Apr 2016 20:26:00,361  INFO [main] UpgradeCatalog222:519 - Updating widget: HDFS Bytes Written
> 11 Apr 2016 20:26:00,373  INFO [main] UpgradeCatalog222:519 - Updating widget: DataNode Process Disk I/O Utilization
> 11 Apr 2016 20:26:00,386  INFO [main] UpgradeCatalog222:519 - Updating widget: DataNode Process Network I/O Utilization
> 11 Apr 2016 20:26:00,395  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode RPC
> 11 Apr 2016 20:26:00,405  INFO [main] UpgradeCatalog222:519 - Updating widget: NN Connection Load
> 11 Apr 2016 20:26:00,415  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode GC count
> 11 Apr 2016 20:26:00,421  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode GC time
> 11 Apr 2016 20:26:00,432  INFO [main] UpgradeCatalog222:449 - Updating YARN widget definition.
> 11 Apr 2016 20:26:00,433  INFO [main] UpgradeCatalog222:519 - Updating widget: Container Failures
> 11 Apr 2016 20:26:00,440  INFO [main] UpgradeCatalog222:519 - Updating widget: Container Failures
> 11 Apr 2016 20:26:00,452  INFO [main] UpgradeCatalog222:519 - Updating widget: App Failures
> 11 Apr 2016 20:26:00,457  INFO [main] UpgradeCatalog222:468 - Updating HBASE widget definition.
> 11 Apr 2016 20:26:00,461  INFO [main] UpgradeCatalog222:519 - Updating widget: Reads and Writes
> 11 Apr 2016 20:26:00,471  INFO [main] UpgradeCatalog222:519 - Updating widget: Blocked Updates
> 11 Apr 2016 20:26:00,484  INFO [main] UpgradeCatalog222:601 - Update widget definition for HDFS corrupted blocks metric
> 11 Apr 2016 20:26:00,494  INFO [main] AbstractUpgradeCatalog:464 - Applying configuration with tag 'version1460406360491' to cluster 'c1'
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46047/
-----------------------------------------------------------

(Updated April 11, 2016, 9:32 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15812
    https://issues.apache.org/jira/browse/AMBARI-15812


Repository: ambari


Description
-------

HDFS, Yarn, HBase widgets that show Counter metrics were changed to use "rate" aggregation function for AMS in AMBARI-15385. However, these changes were not done in Upgrade path.

Hence, these widgets will still request counter data as it is instead of as a Rate metric (._rate).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java fc0e6b2 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java cc5a04d 

Diff: https://reviews.apache.org/r/46047/diff/


Testing (updated)
-------

UpgradeCatalog tests pass.

Manual testing done.

11 Apr 2016 20:26:00,333  INFO [main] UpgradeCatalog222:430 - Updating HDFS widget definition.
11 Apr 2016 20:26:00,342  INFO [main] UpgradeCatalog222:519 - Updating widget: HDFS Bytes Read
11 Apr 2016 20:26:00,361  INFO [main] UpgradeCatalog222:519 - Updating widget: HDFS Bytes Written
11 Apr 2016 20:26:00,373  INFO [main] UpgradeCatalog222:519 - Updating widget: DataNode Process Disk I/O Utilization
11 Apr 2016 20:26:00,386  INFO [main] UpgradeCatalog222:519 - Updating widget: DataNode Process Network I/O Utilization
11 Apr 2016 20:26:00,395  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode RPC
11 Apr 2016 20:26:00,405  INFO [main] UpgradeCatalog222:519 - Updating widget: NN Connection Load
11 Apr 2016 20:26:00,415  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode GC count
11 Apr 2016 20:26:00,421  INFO [main] UpgradeCatalog222:519 - Updating widget: NameNode GC time
11 Apr 2016 20:26:00,432  INFO [main] UpgradeCatalog222:449 - Updating YARN widget definition.
11 Apr 2016 20:26:00,433  INFO [main] UpgradeCatalog222:519 - Updating widget: Container Failures
11 Apr 2016 20:26:00,440  INFO [main] UpgradeCatalog222:519 - Updating widget: Container Failures
11 Apr 2016 20:26:00,452  INFO [main] UpgradeCatalog222:519 - Updating widget: App Failures
11 Apr 2016 20:26:00,457  INFO [main] UpgradeCatalog222:468 - Updating HBASE widget definition.
11 Apr 2016 20:26:00,461  INFO [main] UpgradeCatalog222:519 - Updating widget: Reads and Writes
11 Apr 2016 20:26:00,471  INFO [main] UpgradeCatalog222:519 - Updating widget: Blocked Updates
11 Apr 2016 20:26:00,484  INFO [main] UpgradeCatalog222:601 - Update widget definition for HDFS corrupted blocks metric
11 Apr 2016 20:26:00,494  INFO [main] AbstractUpgradeCatalog:464 - Applying configuration with tag 'version1460406360491' to cluster 'c1'


Thanks,

Aravindan Vijayan