You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/01/06 15:38:00 UTC
[jira] [Commented] (GEODE-9900) Make sure all commands are sending back AuthenticationExpiredException as is
[ https://issues.apache.org/jira/browse/GEODE-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469971#comment-17469971 ]
ASF subversion and git services commented on GEODE-9900:
--------------------------------------------------------
Commit eb6a0dca57cb411eb6cb7ac31906f1e7d111b3b9 in geode's branch refs/heads/develop from Joris Melchior
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eb6a0dc ]
GEODE-9900: ensure AuthenticationExpiredException handling (#7207)
* GEODE-9900: ensure AuthenticationExpiredException handling
- in CloseCQ command
- Add unit tests to confirm proper message is sent
> Make sure all commands are sending back AuthenticationExpiredException as is
> ----------------------------------------------------------------------------
>
> Key: GEODE-9900
> URL: https://issues.apache.org/jira/browse/GEODE-9900
> Project: Geode
> Issue Type: Bug
> Components: client/server, security
> Affects Versions: 1.15.0
> Reporter: Jinmei Liao
> Assignee: Joris Melchior
> Priority: Major
> Labels: GeodeOperationAPI, needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> As we have discovered in GEODE-9820, some commands (especially CQ commands) are not sending back `AuthenticationExpiredException` to the client with MessageType.EXCEPTION, hence causing the client not wrapping it in the correct form (See `AbstractOp around L300), We need to:
> 1. go over all the commands and find out what commands are NOT handling the `AuthenticationExpiredExcpetion` correctly.
> 2. fix these commands, catch `AuthenticationExpiredException` specifically and do a `writeException` (leave all other exception handling intact)
> 3. write tests to make sure we are sending the exception to the client.
> #1 would help us determine how many commands are in need of this fix and size this story correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)