You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/13 17:16:03 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8824:
Re-enable pylint for superset/connectors/base/models.py
codecov-io edited a comment on issue #8824: Re-enable pylint for superset/connectors/base/models.py
URL: https://github.com/apache/incubator-superset/pull/8824#issuecomment-565142050
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=h1) Report
> Merging [#8824](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed54f6ec8dbd4a731eab799e0f86638e457aa460?src=pr&el=desc) will **increase** coverage by `5.94%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8824 +/- ##
==========================================
+ Coverage 65.84% 71.79% +5.94%
==========================================
Files 483 124 -359
Lines 24177 12852 -11325
Branches 2777 0 -2777
==========================================
- Hits 15920 9227 -6693
+ Misses 8079 3625 -4454
+ Partials 178 0 -178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.56% <100%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `40.74% <0%> (-51.86%)` | :arrow_down: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `92.91% <0%> (-1.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `82.24% <0%> (-0.86%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.71% <0%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.92% <0%> (-0.21%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.81% <0%> (-0.17%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| ... and [357 more](https://codecov.io/gh/apache/incubator-superset/pull/8824/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=footer). Last update [ed54f6e...f047e8d](https://codecov.io/gh/apache/incubator-superset/pull/8824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org