You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/26 08:06:00 UTC

[jira] [Commented] (AIRFLOW-4843) Allow orchestration of tasks with Docker Swarm aka `SwarmOperator`

    [ https://issues.apache.org/jira/browse/AIRFLOW-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873049#comment-16873049 ] 

ASF GitHub Bot commented on AIRFLOW-4843:
-----------------------------------------

akki commented on pull request #5483: [AIRFLOW-4843] Allow orchestration via Docker Swarm aka SwarmOperator 
URL: https://github.com/apache/airflow/pull/5483
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [AIRFLOW-4843](https://issues.apache.org/jira/browse/AIRFLOW-4843/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-4843
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
          Added in issue - https://issues.apache.org/jira/browse/AIRFLOW-4843
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
       `SwarmOperatorTestCase`
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow orchestration of tasks with Docker Swarm aka `SwarmOperator`
> ------------------------------------------------------------------
>
>                 Key: AIRFLOW-4843
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4843
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: operators
>    Affects Versions: 1.10.3
>            Reporter: Akshesh Doshi
>            Assignee: Akshesh Doshi
>            Priority: Major
>              Labels: Docker, docker, orchestration, swarm
>
> Currently, Airflow supports spawning Docker containers for running tasks via the {color:#707070}_DockerOperator_{color} but these containers are run on the same node as the scheduler.
> It would be helpful for our use-case to be able to spawn these tasks wherever resources are available in our Docker Swarm cluster.
>  
> This can be achieved by creating a Docker swarm service, waiting for its run and removing it after it has completed execution.
> This approach has been suggested/discussed at various places (and implemented in Golang for Swarm-cronjob):
> [https://blog.alexellis.io/containers-on-swarm/]
> [https://forums.docker.com/t/running-one-off-commands-in-swarm-containers/42436/3]
> [https://gist.github.com/alexellis/e11321b8fbfc595c208ea3e74bf5e54b]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)