You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by yegortokmakov <gi...@git.apache.org> on 2016/01/26 20:02:21 UTC
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
GitHub user yegortokmakov opened a pull request:
https://github.com/apache/storm/pull/1049
STORM-1494 Link to supervisor logs form UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yegortokmakov/storm STORM-1494
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1049.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1049
----
commit 21f56e91efd4af4a8b2c54d6ba6b50b717f2aca7
Author: Yegor Tokmakov <ye...@tokmakov.biz>
Date: 2016-01-26T18:58:59Z
Link to supervisor logs form UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175378568
+1
For now I'd say it should be applied to the 1.x branch. Master should be considered as well, since the .clj files involved haven't really come into play yet, in terms of migration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175275852
+1
Since this modifies clj file, we may want to decide how to apply this to master.
Would it better to merge to 1.x first and just leave notice? Or do we just want to change PR's destination to master, and doing backport?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by yegortokmakov <gi...@git.apache.org>.
Github user yegortokmakov commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175180562
I've also removed not used argument in nimbus-log-link
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175263760
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175250031
LGTM! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1494 Link to supervisor logs form UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---