You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@apache.org on 2005/09/18 02:13:56 UTC
svn commit: r289871 - in /struts/shale/trunk/core-library: build.xml
src/test/org/apache/shale/util/TokenProcessorTestCase.java
Author: craigmcc
Date: Sat Sep 17 17:13:51 2005
New Revision: 289871
URL: http://svn.apache.org/viewcvs?rev=289871&view=rev
Log:
Windows does not seem to like Thread.sleep(2), so change the test methodology
to just generate 1000 unique tokens.
Also, fix a typo in the build.xml to actually enable assertions for the tests.
Modified:
struts/shale/trunk/core-library/build.xml
struts/shale/trunk/core-library/src/test/org/apache/shale/util/TokenProcessorTestCase.java
Modified: struts/shale/trunk/core-library/build.xml
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/build.xml?rev=289871&r1=289870&r2=289871&view=diff
==============================================================================
--- struts/shale/trunk/core-library/build.xml (original)
+++ struts/shale/trunk/core-library/build.xml Sat Sep 17 17:13:51 2005
@@ -419,7 +419,7 @@
haltonfailure="${test.haltonfailure}"
printSummary="no">
- <jvmarg value="-enableassertions:org.apache.shale..."/>
+ <jvmarg value="-Denableassertions:org.apache.shale..."/>
<classpath refid="test.classpath"/>
<formatter type="plain"
usefile="false"/>
Modified: struts/shale/trunk/core-library/src/test/org/apache/shale/util/TokenProcessorTestCase.java
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/test/org/apache/shale/util/TokenProcessorTestCase.java?rev=289871&r1=289870&r2=289871&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/test/org/apache/shale/util/TokenProcessorTestCase.java (original)
+++ struts/shale/trunk/core-library/src/test/org/apache/shale/util/TokenProcessorTestCase.java Sat Sep 17 17:13:51 2005
@@ -87,16 +87,14 @@
// Create a bunch of tokens
for (int i = 0; i < 1000; i++) {
- String token = tp.generate(facesContext);
- if (set.contains(token)) {
- fail("Token set already contains '" + token + "'");
+ String token = null;
+ while (true) {
+ token = tp.generate(facesContext);
+ if (!set.contains(token)) {
+ break;
+ }
}
set.add(token);
- try {
- Thread.sleep(2);
- } catch (InterruptedException e) {
- ;
- }
}
// Ensure that we can verify all of them
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org