You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/16 12:33:14 UTC
[GitHub] [commons-lang] pedro-borges opened a new pull request #509: Update
DurationFormatUtils.java
pedro-borges opened a new pull request #509: Update DurationFormatUtils.java
URL: https://github.com/apache/commons-lang/pull/509
It is not correct to return 0 seconds for a 100ms duration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #509: Update
DurationFormatUtils.java
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #509: Update DurationFormatUtils.java
URL: https://github.com/apache/commons-lang/pull/509#issuecomment-614716973
-1 This is wrong IMO, not only we would be changing the format of the returned string, but the information would still be incorrect.
An alternative would be to change:
```
"d' days 'H' hours 'm' minutes 's' seconds'"
```
to
```
"d' days 'H' hours 'm' minutes 's' seconds' 'm' milliseconds"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services