You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/18 12:38:24 UTC
[GitHub] [flink] godfreyhe commented on a change in pull request #10196:
[FLINK-14789] [table-planner-blink] extends max/min type in ColumnStats
from Number to Comparable
godfreyhe commented on a change in pull request #10196: [FLINK-14789] [table-planner-blink] extends max/min type in ColumnStats from Number to Comparable
URL: https://github.com/apache/flink/pull/10196#discussion_r347356879
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/plan/stats/ColumnStats.java
##########
@@ -115,20 +189,81 @@ public String toString() {
if (max != null) {
columnStats.add("max=" + max);
}
+ if (maxValue != null) {
Review comment:
`max` and `maxValue` could not be null both, so only one `max` will print if the value is not null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services