[GitHub] lebeg commented on a change in pull request #10202: [MXNET-131] Refine build.py, misc fixes, tweak commandline, add help

[GitBox <gi...@apache.org>]

lebeg commented on a change in pull request #10202: [MXNET-131] Refine build.py, misc fixes, tweak commandline, add help
URL: https://github.com/apache/incubator-mxnet/pull/10202#discussion_r176471836
 
 

 ##########
 File path: ci/build.py
 ##########
 @@ -147,30 +176,65 @@ def script_name() -> str:
     docker_binary = get_docker_binary(args.nvidiadocker)
 
     if args.list:
-        platforms = get_platforms()
-        print(platforms)
+        list_platforms()
 
     elif args.platform:
         platform = args.platform
-        if args.build:
+        if args.build or args.build_only:
             build_docker(platform, docker_binary)
+        if args.build_only:
+            return 0
         tag = get_docker_tag(platform)
         if command:
             container_run(platform, docker_binary, command)
+        elif args.docker_run:
+            print(container_run(platform, docker_binary, [""], True))
         else:
             cmd = ["/work/mxnet/ci/docker/runtime_functions.sh", "build_{}".format(platform)]
             logging.info("No command specified, trying default build: %s", ' '.join(cmd))
             container_run(platform, docker_binary, cmd)
 
-    else:
+    elif args.all:
         platforms = get_platforms()
         logging.info("Building for all architectures: {}".format(platforms))
         logging.info("Artifacts will be produced in the build/ directory.")
         for platform in platforms:
             build_docker(platform, docker_binary)
+            if args.build_only:
+                continue
             cmd = ["/work/mxnet/ci/docker/runtime_functions.sh", "build_{}".format(platform)]
-            logging.info("No command specified, trying default build: %s", ' '.join(cmd))
+            shutil.rmtree(buildir(), ignore_errors=True)
             container_run(platform, docker_binary, cmd)
+            plat_buildir = os.path.join(get_mxnet_root(), "build_{}".format(platform))
 
 Review comment:
   Maybe "build.{}".format(platform)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services