[GitHub] [zookeeper] hanm commented on pull request #1492: ZOOKEEPER-3419: Backup and recovery support.

[GitBox <gi...@apache.org>]

hanm commented on pull request #1492:
URL: https://github.com/apache/zookeeper/pull/1492#issuecomment-730136643


   @narendly thank you for feedback. 
   
   >> Generifying components such as the storage provider implementation
   
   yes a more generalized storage provider interface is of my interest as well. something like org.apache.hadoop.fs.FileSystem would probably fit the needs here and then we can have various implementations including backup storage on s3, azure, and google cloud and so on which will be interesting.
   
   >> Adding support for interface that will allow timestamp-Zxid translation
   
   Interesting, i'll think about this.
   
   >> Hoping to offer some alternatives to the components proprietary to Twitter
   
   yes the twitter specific internal stuff will be removed - which is required for this PR to be considered mergeable.
   
   >> should we move this discussion to ZooKeeper Atlassian wiki/JIRA
   
   It's find to discuss here - the comments will be bridged automatically to Apache JIRA tickets (in work log tab IIRC).
   
   >> add some sort of leader-election protocol for redundancy among the nodes whose backup.enabled is set to true. I know there's a comment block in this change 
   
   which specific "comment block" you were referring to? do you mind elaborate the use case of "leader-election protocol"? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org