You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/09/22 13:31:21 UTC
[PR] CAMEL-24906: camel-yaml-dsl-validator - the quote hints print the line to write, and a doubled closing quote says so [camel]
davsclaus opened a new pull request, #26749:
URL: https://github.com/apache/camel/pull/26749
Fixes https://issues.apache.org/jira/browse/CAMEL-24906 (part of CAMEL-24886)
CAMEL-24888 taught the validator to name a double-quoted value that never closes, with a message that described the edit: "end it with a `"` after the last character". In the next stepwise run the local model answered it by appending a quote to a line that already had one, seven times in one run of four examples, always the same JSONPath filter, and then hit the older "the value continues after its closing quote" message, which explains concatenation and does not fit.
Both messages now give the line to write:
```
line 8: the value opens a double quote and never closes it; write the line as
expression: "$[?(@.sku == '${header.sku}')]" (a single quote inside a double-quoted value needs no escape)
line 8: the value of expression ends with two double quotes; remove the extra one and write the line as
expression: "$[?(@.sku == '${header.sku}')]"
```
Tests in `YamlValidatorPropertyHintTest` for both, and verified on the CLI with `camel validate yaml`. A JSONPath with single quotes inside a double-quoted scalar is the shape of every filter in the REST examples, so this one line gates that rung.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24906: camel-yaml-dsl-validator - the quote hints print the line to write, and a doubled closing quote says so [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/camel/pull/26749#issuecomment-5778663646
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-yaml-dsl/camel-yaml-dsl-validator`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 8 of 692 tested, 9 compile-only — current: 8 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **17 affected modules** (current approach: 8).
**Skip-tests mode would test 8 modules** (1 direct + 7 downstream), **skip tests for 9** (generated code, meta-modules)
<details><summary>:warning: Modules only in Scalpel (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
<details><summary>Modules Scalpel would test (8)</summary>
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-yaml-dsl-validator` ← dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/main/java/org/apache/camel/dsl/yaml/validator/YamlValidator.java, dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/test/java/org/apache/camel/dsl/yaml/validator/YamlValidatorPropertyHintTest.java
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (17 modules, 3m 50s total)</summary>
**Total reactor time:** 3m 50s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: JBang :: Plugin :: TUI | 56.4s | SUCCESS |
| Camel :: Launcher | 54.1s | SUCCESS |
| Camel :: JBang :: MCP | 42.4s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 25.0s | SUCCESS |
| Camel :: YAML DSL :: Validator | 13.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 11.5s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 9.2s | SUCCESS |
| Camel :: Coverage | 5.4s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 3.7s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.8s | SUCCESS |
| Camel :: JBang :: Integration tests | 1.3s | SUCCESS |
| Camel :: JBang :: Main | 0.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.8s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: JBang :: Plugin :: TUI` (56.4s)
- `Camel :: Launcher` (54.1s)
- `Camel :: JBang :: MCP` (42.4s)
- `Camel :: JBang :: Plugin :: Kubernetes` (25.0s)
- `Camel :: YAML DSL :: Validator` (13.0s)
- `Camel :: JBang :: Plugin :: Testing` (11.5s)
- `Camel :: JBang :: Plugin :: Validate` (9.2s)
- `Camel :: Coverage` (5.4s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (3.7s)
- `Camel :: JBang :: Plugin :: MCP` (1.9s)
- `Camel :: JBang :: Plugin :: Edit` (1.9s)
- `Camel :: JBang :: Plugin :: Generate` (1.8s)
- `Camel :: JBang :: Integration tests` (1.3s)
- `Camel :: JBang :: Main` (0.9s)
- `Camel :: JBang :: Plugin :: Route Parser` (0.9s)
- `Camel :: Launcher :: Container` (0.8s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35734012632)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24906: camel-yaml-dsl-validator - the quote hints print the line to write, and a doubled closing quote says so [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/camel/pull/26749#issuecomment-5777475675
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24906: camel-yaml-dsl-validator - the quote hints print the line to write, and a doubled closing quote says so [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26749:
URL: https://github.com/apache/camel/pull/26749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org