You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/09/23 20:45:24 UTC
[PR] Fix broken main: generated JS types [airflow]
jscheffl opened a new pull request, #42422:
URL: https://github.com/apache/airflow/pull/42422
Fix for static checks in https://github.com/apache/airflow/actions/runs/10995403123/job/30526485436
@pierrejeambrun was the API change intended that causes the generated DIFF? Or is this an unwanted side-effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken main: generated JS types [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #42422:
URL: https://github.com/apache/airflow/pull/42422#issuecomment-2369372637
Static checks green now... others still fail, therefore merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken main: generated JS types [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #42422:
URL: https://github.com/apache/airflow/pull/42422#issuecomment-2370585333
https://github.com/apache/airflow/pull/42435 Hook wasn't re-wired on the new generated OpenAPI spec used by the front end, causing main failure. Thanks Jens shouldn't happen anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken main: generated JS types [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #42422:
URL: https://github.com/apache/airflow/pull/42422#issuecomment-2370566780
Hmmm this particular hook `ts-compile-format-lint-ui` was skipped, file detection is wrong I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken main: generated JS types [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #42422:
URL: https://github.com/apache/airflow/pull/42422#issuecomment-2370558154
Thanks, yes the change is intended, but I do not understand why this didn't break in my PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix broken main: generated JS types [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #42422:
URL: https://github.com/apache/airflow/pull/42422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org