You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <b....@competence.biz> on 2008/11/13 14:28:56 UTC

RE: Branching 1.6.x this week (dirent_uri)

> -----Original Message-----
> From: Lieven Govaerts [mailto:svnlgo{a}mobsol.be]
> Sent: maandag 10 november 2008 20:32
> To: dev@subversion.tigris.org
> Subject: Re: Branching 1.6.x this week
> 
> 
> So, I haven't had time to finish the dirent_uri stuff which I started
> to
> add during the month October. The problem is that the new interface
> isn't finished, and AFAIC shouldn't be exposed yet.
> 
> I don't have time to make this change in the coming days or weeks, so
> I'd like to ask if someone can move the file dirent_uri.h out of the
> public area (except for svn_dirent_is_root). That should do it
> normally.
> This gives me some time to finish it up before 1.7.

	Hi Lieven,

What are the open issues on this? Is it possible for somebody else to
resolve the few loose ends there are?

The code is in use in quite some places (the old public api uses the new
functions), but there are other places that use the old api that indirectly
calls svn_dirent*.

When I look through it, it seems most dirent and url public api's are
completed, but are not used everywhere they should. Doing a massive rename
to make the api internal just to make it public in 1.7 doesn't feel ok.

The current code should to improve the Windows handling and I like the extra
url and dirent normalization changes.

Thanks,
	Bert

> 
> thanks and sorry,
> 
> Lieven


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Branching 1.6.x this week (dirent_uri)

Posted by Greg Stein <gs...@gmail.com>.
On Sat, Nov 15, 2008 at 1:41 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>...
> I'm more afraid that we'd introduce an API that isn't finished yet,
> which we have to rev in 1.7. My plan was to deprecate svn_path* at the
> same time as we introduce svn_[dirent|uri].

Oh, don't worry about that. The original API will remain and be
completely functional. Sure, 1.7 will have a "better" API, but if
anybody codes to the 1.6 API, then they'll be just fine all the way
into the future.

Shoot. I've already deprecated an API or three that was introduced in 1.5. :-)

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Branching 1.6.x this week (dirent_uri)

Posted by Julian Foad <ju...@btopenworld.com>.
On Sat, 2008-11-15 at 22:41 +0100, Lieven Govaerts wrote:
> Bert Huijben wrote:
> >> -----Original Message-----
> >> From: Lieven Govaerts [mailto:svnlgo{a}mobsol.be]
> >> Sent: maandag 10 november 2008 20:32
> >> To: dev@subversion.tigris.org
> >> Subject: Re: Branching 1.6.x this week
> >>
> >>
> >> So, I haven't had time to finish the dirent_uri stuff which I started
> >> to
> >> add during the month October. The problem is that the new interface
> >> isn't finished, and AFAIC shouldn't be exposed yet.
> >>
> >> I don't have time to make this change in the coming days or weeks, so
> >> I'd like to ask if someone can move the file dirent_uri.h out of the
> >> public area (except for svn_dirent_is_root). That should do it
> >> normally.
> >> This gives me some time to finish it up before 1.7.
> > 
> > 	Hi Lieven,
> > 
> > What are the open issues on this? Is it possible for somebody else to
> > resolve the few loose ends there are?
> > 
> 
> Well, since the svn_[dirent|uri] stuff is a whole new API, now might be
> a good moment to make sure that API is better than the original. So,
> things like passing a pool parameter, return svn_error_t on all
> functions etc.
> 
> Besides that, the API is not complete yet. For some functions we have
> the svn_uri variant but not svn_dirent or visa versa.
> Then there is the is_absolute function, which thinks "E:foo" is an
> absolute path.
> 
> > The code is in use in quite some places (the old public api uses the new
> > functions), but there are other places that use the old api that indirectly
> > calls svn_dirent*.
> 
> I thought only svn_dirent_is_root is used in other places than path.c.
> 
> > 
> > When I look through it, it seems most dirent and url public api's are
> > completed, but are not used everywhere they should. Doing a massive rename
> > to make the api internal just to make it public in 1.7 doesn't feel ok.
> > 
> 
> I'm more afraid that we'd introduce an API that isn't finished yet,
> which we have to rev in 1.7. My plan was to deprecate svn_path* at the
> same time as we introduce svn_[dirent|uri].
> 
> Lieven

Looks like this should be a TODO-1.6 item. Adding it...

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1010183

Re: Branching 1.6.x this week (dirent_uri)

Posted by Lieven Govaerts <sv...@mobsol.be>.
Bert Huijben wrote:
>> -----Original Message-----
>> From: Lieven Govaerts [mailto:svnlgo{a}mobsol.be]
>> Sent: maandag 10 november 2008 20:32
>> To: dev@subversion.tigris.org
>> Subject: Re: Branching 1.6.x this week
>>
>>
>> So, I haven't had time to finish the dirent_uri stuff which I started
>> to
>> add during the month October. The problem is that the new interface
>> isn't finished, and AFAIC shouldn't be exposed yet.
>>
>> I don't have time to make this change in the coming days or weeks, so
>> I'd like to ask if someone can move the file dirent_uri.h out of the
>> public area (except for svn_dirent_is_root). That should do it
>> normally.
>> This gives me some time to finish it up before 1.7.
> 
> 	Hi Lieven,
> 
> What are the open issues on this? Is it possible for somebody else to
> resolve the few loose ends there are?
> 

Well, since the svn_[dirent|uri] stuff is a whole new API, now might be
a good moment to make sure that API is better than the original. So,
things like passing a pool parameter, return svn_error_t on all
functions etc.

Besides that, the API is not complete yet. For some functions we have
the svn_uri variant but not svn_dirent or visa versa.
Then there is the is_absolute function, which thinks "E:foo" is an
absolute path.

> The code is in use in quite some places (the old public api uses the new
> functions), but there are other places that use the old api that indirectly
> calls svn_dirent*.

I thought only svn_dirent_is_root is used in other places than path.c.

> 
> When I look through it, it seems most dirent and url public api's are
> completed, but are not used everywhere they should. Doing a massive rename
> to make the api internal just to make it public in 1.7 doesn't feel ok.
> 

I'm more afraid that we'd introduce an API that isn't finished yet,
which we have to rev in 1.7. My plan was to deprecate svn_path* at the
same time as we introduce svn_[dirent|uri].

Lieven


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org