You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2016/05/27 20:20:10 UTC

Review Request 47980: Make default build profile for External HBase and Solr

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47980/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-833
    https://issues.apache.org/jira/browse/ATLAS-833


Repository: atlas


Description
-------

The default build profile should set the distribution configuration to be external HBase and Solr.


The profile external-hbase-solr will not package HBase and Solr with the Atlas distribution but will configure atlas-application.properties for and external HBase and Solr.


Diffs
-----

  distro/pom.xml 22f70ae 
  distro/src/conf/atlas-application.properties bb12538 
  distro/src/conf/atlas-env.sh c671c45 
  docs/src/site/twiki/Configuration.twiki f532a73 
  docs/src/site/twiki/InstallationSteps.twiki fe6b4a7 

Diff: https://reviews.apache.org/r/47980/diff/


Testing
-------

Tested all profiles to verify desired configuration and packaging.  Verified that the default is for external HBase and Solr.


Thanks,

Tom Beerbower


Re: Review Request 47980: Make default build profile for External HBase and Solr

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47980/#review135606
-----------------------------------------------------------


Fix it, then Ship it!




Looks OK to me. I have tested the default profile and the embedded profiles. They are working fine. If the below documentation is added, I think it would be more complete.


docs/src/site/twiki/InstallationSteps.twiki (line 17)
<https://reviews.apache.org/r/47980/#comment200637>

    When built with this profile, we need a few specific steps to ensure Atlas is functional. In my testing these including:
    
    * Configuring atlas.graph.storage.hostname
    * Configuring atlas.graph.index.search.solr.zookeeper-url
    * Setting HBASE_CONF_DIR to point to a valid HBase config directory
    * Creating the SOLR indices.
    
    Since this profile is new to our system, I think it would be useful to have some documentation for the same.


- Hemanth Yamijala


On May 27, 2016, 8:20 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47980/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 8:20 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-833
>     https://issues.apache.org/jira/browse/ATLAS-833
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The default build profile should set the distribution configuration to be external HBase and Solr.
> 
> 
> The profile external-hbase-solr will not package HBase and Solr with the Atlas distribution but will configure atlas-application.properties for and external HBase and Solr.
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml 22f70ae 
>   distro/src/conf/atlas-application.properties bb12538 
>   distro/src/conf/atlas-env.sh c671c45 
>   docs/src/site/twiki/Configuration.twiki f532a73 
>   docs/src/site/twiki/InstallationSteps.twiki fe6b4a7 
> 
> Diff: https://reviews.apache.org/r/47980/diff/
> 
> 
> Testing
> -------
> 
> Tested all profiles to verify desired configuration and packaging.  Verified that the default is for external HBase and Solr.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 47980: Make default build profile for External HBase and Solr

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47980/#review135648
-----------------------------------------------------------


Ship it!




Ship It!

- Hemanth Yamijala


On May 31, 2016, 2:47 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47980/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 2:47 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-833
>     https://issues.apache.org/jira/browse/ATLAS-833
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The default build profile should set the distribution configuration to be external HBase and Solr.
> 
> 
> The profile external-hbase-solr will not package HBase and Solr with the Atlas distribution but will configure atlas-application.properties for and external HBase and Solr.
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml 22f70ae 
>   distro/src/conf/atlas-application.properties bb12538 
>   distro/src/conf/atlas-env.sh c671c45 
>   docs/src/site/twiki/Configuration.twiki f532a73 
>   docs/src/site/twiki/InstallationSteps.twiki fe6b4a7 
> 
> Diff: https://reviews.apache.org/r/47980/diff/
> 
> 
> Testing
> -------
> 
> Tested all profiles to verify desired configuration and packaging.  Verified that the default is for external HBase and Solr.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 47980: Make default build profile for External HBase and Solr

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47980/
-----------------------------------------------------------

(Updated May 31, 2016, 2:47 p.m.)


Review request for atlas.


Changes
-------

Updated doc for external-hbase-solr profile.


Bugs: ATLAS-833
    https://issues.apache.org/jira/browse/ATLAS-833


Repository: atlas


Description
-------

The default build profile should set the distribution configuration to be external HBase and Solr.


The profile external-hbase-solr will not package HBase and Solr with the Atlas distribution but will configure atlas-application.properties for and external HBase and Solr.


Diffs (updated)
-----

  distro/pom.xml 22f70ae 
  distro/src/conf/atlas-application.properties bb12538 
  distro/src/conf/atlas-env.sh c671c45 
  docs/src/site/twiki/Configuration.twiki f532a73 
  docs/src/site/twiki/InstallationSteps.twiki fe6b4a7 

Diff: https://reviews.apache.org/r/47980/diff/


Testing
-------

Tested all profiles to verify desired configuration and packaging.  Verified that the default is for external HBase and Solr.


Thanks,

Tom Beerbower