You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by CalvinKirs <ac...@163.com> on 2020/08/06 12:25:39 UTC

[DISCUSS]DDL operation result judgment


I noticed that many of our codes do not judge the success status of the execution result (affecting the number of rows) when performing DDL-related operations. In some cases, we should care about its execution status instead of defaulting to its successful execution.
We may want to discuss those situations where we must pay attention, and those situations where we don’t need to pay attention.




我在修复sonar的一些bug的时候，注意到我们很多代码在执行DDL相关操作的时候没有去判断执行结果的成功状态（影响行数），在某些情况下，我们应该关心它的一个执行状态，而不是默认它执行成功。
我们可能要讨论一下那些情况下必须关注，那些情况下我们无需关注。
Best  wishes！
CalvinKirs

Re： [DISCUSS]DDL operation result judgment

Posted by Yichao Yang <10...@qq.com>.
+1.




------------------&nbsp;原始邮件&nbsp;------------------
发件人:                                                                                                                        "dev"                                                                                    <gabrywu@apache.org&gt;;
发送时间:&nbsp;2020年8月7日(星期五) 上午10:23
收件人:&nbsp;"dev@dolphinscheduler.apache.org"<dev@dolphinscheduler.apache.org&gt;;

主题:&nbsp;Re: [DISCUSS]DDL operation result judgment



Yes, JDBC issue is a fatal one, we should take necessary actions to avoid it 


On 2020/8/6, 20:26, "CalvinKirs" <acm_master@163.com&gt; wrote:



&nbsp;&nbsp;&nbsp; I noticed that many of our codes do not judge the success status of the execution result (affecting the number of rows) when performing DDL-related operations. In some cases, we should care about its execution status instead of defaulting to its successful execution.
&nbsp;&nbsp;&nbsp; We may want to discuss those situations where we must pay attention, and those situations where we don’t need to pay attention.




&nbsp;&nbsp;&nbsp; 我在修复sonar的一些bug的时候，注意到我们很多代码在执行DDL相关操作的时候没有去判断执行结果的成功状态（影响行数），在某些情况下，我们应该关心它的一个执行状态，而不是默认它执行成功。
&nbsp;&nbsp;&nbsp; 我们可能要讨论一下那些情况下必须关注，那些情况下我们无需关注。
&nbsp;&nbsp;&nbsp; Best&nbsp; wishes！
&nbsp;&nbsp;&nbsp; CalvinKirs

Re: [DISCUSS]DDL operation result judgment

Posted by wu shaoj <ga...@apache.org>.
Yes, JDBC issue is a fatal one, we should take necessary actions to avoid it 


On 2020/8/6, 20:26, "CalvinKirs" <ac...@163.com> wrote:



    I noticed that many of our codes do not judge the success status of the execution result (affecting the number of rows) when performing DDL-related operations. In some cases, we should care about its execution status instead of defaulting to its successful execution.
    We may want to discuss those situations where we must pay attention, and those situations where we don’t need to pay attention.




    我在修复sonar的一些bug的时候，注意到我们很多代码在执行DDL相关操作的时候没有去判断执行结果的成功状态（影响行数），在某些情况下，我们应该关心它的一个执行状态，而不是默认它执行成功。
    我们可能要讨论一下那些情况下必须关注，那些情况下我们无需关注。
    Best  wishes！
    CalvinKirs

Re: [DISCUSS]DDL operation result judgment

Posted by CalvinKirs <ac...@163.com>.
We need to list the affected codes to Luo.




| |
Kirs
|
|
邮箱：acm_master@163.com
|

Signature is customized by Netease Mail Master

On 08/06/2020 20:25, CalvinKirs wrote:


I noticed that many of our codes do not judge the success status of the execution result (affecting the number of rows) when performing DDL-related operations. In some cases, we should care about its execution status instead of defaulting to its successful execution.
We may want to discuss those situations where we must pay attention, and those situations where we don’t need to pay attention.




我在修复sonar的一些bug的时候，注意到我们很多代码在执行DDL相关操作的时候没有去判断执行结果的成功状态（影响行数），在某些情况下，我们应该关心它的一个执行状态，而不是默认它执行成功。
我们可能要讨论一下那些情况下必须关注，那些情况下我们无需关注。
Best  wishes！
CalvinKirs