You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/10 21:04:40 UTC

[GitHub] [accumulo] ctubbsii commented on issue #1584: Moved ThriftClientHandler out of TabletServer for #1581

ctubbsii commented on issue #1584: Moved ThriftClientHandler out of TabletServer for #1581
URL: https://github.com/apache/accumulo/pull/1584#issuecomment-612217214
 
 
   Merging master onto your branch would have been okay if you need to pick up changes from there. It's just the force-push that breaks things... it causes all review comments to become automatically obsolete, and it makes it extremely difficult, if not impossible, to view what changed from the last code review. So, a code reviewer basically has to start over, reviewing from scratch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services