You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2008/07/05 13:28:56 UTC

Re: svn commit: r674134 - in /maven/plugins/trunk/maven-site-plugin/src/main/resources: site-plugin_ca.properties site-plugin_sv.properties site-plugin_tr.properties

I never really closed out the discussion we had earlier, regarding how 
to encode properties files. Now we have an example of a change of 
encoding of properties, so I want to take the opportunity to finish that 
discussion. Hopefully we can reach consensus this time :-) When we do 
I'll put into our code conventions docs.

What is the benefit of the change you made here Vincent?

I proof read the Swedish translation (one of the files changed here) 
that was submitted earlier, before I committed it. When I look at the 
file now, it is totally unreadable for a human. That's because the 
accented character, found in ISO-8859-1 but not in ASCII, are now 
represented by unicode. How can I proof read such a document if it was 
submitted in unicode? Therefor I see more pain than gain from this type 
of change.



vsiveton@apache.org wrote:
> Author: vsiveton
> Date: Fri Jul  4 15:53:58 2008
> New Revision: 674134
> 
> URL: http://svn.apache.org/viewvc?rev=674134&view=rev
> Log:
> o used unicode provided by Properties Editor Eclipse Plugin
> 
> Modified:
>     maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_ca.properties
>     maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_sv.properties
>     maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_tr.properties
> 
> Modified: maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_ca.properties
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_ca.properties?rev=674134&r1=674133&r2=674134&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_ca.properties (original)
> +++ maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_ca.properties Fri Jul  4 15:53:58 2008
> @@ -15,12 +15,12 @@
>  # specific language governing permissions and limitations
>  # under the License.
>  
> -report.category.column.description = Descripció
> +report.category.column.description = Descripci\u00f3
>  report.category.column.document    = Document
>  report.category.sectionTitle       = Resum
> -report.information.description1    = Aquest document presenta un resum dels diferents documents i enllaços que són part de la informació general del projecte. Tot aquest contingut és generat automàticament per
> +report.information.description1    = Aquest document presenta un resum dels diferents documents i enlla\u00e7os que s\u00f3n part de la informaci\u00f3 general del projecte. Tot aquest contingut \u00e9s generat autom\u00e0ticament per
>  report.information.description2    = en nom d'aquest projecte.
> -report.information.title           = Informació general del projecte
> -report.project.description1        = Aquest document presenta un resum de diversos informes que són generats automàticament per
> -report.project.description2        = Cada informe està descrit breument més endavant.
> +report.information.title           = Informaci\u00f3 general del projecte
> +report.project.description1        = Aquest document presenta un resum de diversos informes que s\u00f3n generats autom\u00e0ticament per
> +report.project.description2        = Cada informe est\u00e0 descrit breument m\u00e9s endavant.
>  report.project.title               = Informes Generats per Maven
> 
> Modified: maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_sv.properties
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_sv.properties?rev=674134&r1=674133&r2=674134&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_sv.properties (original)
> +++ maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_sv.properties Fri Jul  4 15:53:58 2008
> @@ -17,10 +17,10 @@
>  
>  report.category.column.description = Beskrivning
>  report.category.column.document    = Dokument
> -report.category.sectionTitle       = Översikt
> -report.information.description1    = Detta dokument ger en översikt över de dokument och länkar som utgör projektets generella information. Allt innehåll genereras automatiskt av
> -report.information.description2    = åt projektet.
> +report.category.sectionTitle       = \u00d6versikt
> +report.information.description1    = Detta dokument ger en \u00f6versikt \u00f6ver de dokument och l\u00e4nkar som utg\u00f6r projektets generella information. Allt inneh\u00e5ll genereras automatiskt av
> +report.information.description2    = \u00e5t projektet.
>  report.information.title           = Projektinformation
> -report.project.description1        = Detta dokument ger en översikt över de rapporter som genereras av
> +report.project.description1        = Detta dokument ger en \u00f6versikt \u00f6ver de rapporter som genereras av
>  report.project.description2        = Varje rapport beskrivs kort nedan.
>  report.project.title               = Projektrapporter
> 
> Modified: maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_tr.properties
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_tr.properties?rev=674134&r1=674133&r2=674134&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_tr.properties (original)
> +++ maven/plugins/trunk/maven-site-plugin/src/main/resources/site-plugin_tr.properties Fri Jul  4 15:53:58 2008
> @@ -15,12 +15,12 @@
>  # specific language governing permissions and limitations
>  # under the License.
>  
> -report.category.column.description = Taným
> -report.category.column.document    = Doküman
> -report.category.sectionTitle       = Genel Bakýþ
> +report.category.column.description = Tan\u00fdm
> +report.category.column.document    = Dok\u00fcman
> +report.category.sectionTitle       = Genel Bak\u00fd\u00fe
>  report.information.description1    = This document provides an overview of the various documents and links that are part of this project's general information. All of this content is automatically generated by
>  report.information.description2    = on behalf of the project.
>  report.information.title           = Proje Bilgileri
>  report.project.description1        = This document provides an overview of the various reports that are automatically generated by
>  report.project.description2        = Each report is briefly described below.
> -report.project.title               = Geliþtirilmiþ Raporlar
> +report.project.title               = Geli\u00fetirilmi\u00fe Raporlar
> 
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r674134 - in /maven/plugins/trunk/maven-site-plugin/src/main/resources: site-plugin_ca.properties site-plugin_sv.properties site-plugin_tr.properties

Posted by Benjamin Bentmann <be...@udo.edu>.
Vincent Siveton wrote:

> So, I am in favour to use unicode to all resources bundles. What others think?

To repeat my argument from MSITE-287: I believe using ASCII only with 
Unicode escapes is simply the most robust choice for an international 
dev community. For instance, somebody who accidentially edits a Latin-1 
resource bundle using UTF-8 will corrupt the contents. An ASCII-only 
resource bundle in contrast is safe(r) because the characters will 
successfully rountrip regardless of the encoding (neglecting exots like 
EBCDIC).


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r674134 - in /maven/plugins/trunk/maven-site-plugin/src/main/resources: site-plugin_ca.properties site-plugin_sv.properties site-plugin_tr.properties

Posted by Vincent Siveton <vi...@gmail.com>.
Hi Dennis,

2008/7/5, Dennis Lundberg <de...@apache.org>:
> I never really closed out the discussion we had earlier, regarding how to
> encode properties files. Now we have an example of a change of encoding of
> properties, so I want to take the opportunity to finish that discussion.
> Hopefully we can reach consensus this time :-) When we do I'll put into our
> code conventions docs.

+1 to create a Properties convention part.
Also, specify how to format key/value, ie having a consensus between
[1] or [2] layout.

>
>  What is the benefit of the change you made here Vincent?

Mainly for consistency reasons with other resources bundles.
Also, it is a no cost issue since it is done by development tools.

>
>  I proof read the Swedish translation (one of the files changed here) that
> was submitted earlier, before I committed it. When I look at the file now,
> it is totally unreadable for a human. That's because the accented character,
> found in ISO-8859-1 but not in ASCII, are now represented by unicode. How
> can I proof read such a document if it was submitted in unicode? Therefor I
> see more pain than gain from this type of change.
>

I understand your requirement about readability but modern IDEs
provide a way to convert native to ascii transparently.
In Eclipse world, you could use PropertiesEditor Plugin [3] (Take care
to change the default encoding to UTF-8, ie select Window >
Preferences and open up the configuration for PropertiesEditor)
In IDEA, you could select "transparent native-to-ascii conversion"
parameter in File > Settings and open up the General item.
Finally, some independent tools could help you [4] and [5].

So, I am in favour to use unicode to all resources bundles. What others think?

Cheers,

Vincent

[1] https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-changelog-plugin/src/main/resources/scm-activity.properties
[2] https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-project-info-reports-plugin/src/main/resources/project-info-report_fr.properties

[3] http://propedit.sourceforge.jp/
[4] http://propedit.sourceforge.jp/propertieseditor.jnlp
[5] http://www.zaval.org/products/jrc-editor/index.html

[SNIP]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org