You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/24 13:24:20 UTC

[GitHub] [airflow] ashb commented on a change in pull request #11335: Make Dag Serialization a hard requirement

ashb commented on a change in pull request #11335:
URL: https://github.com/apache/airflow/pull/11335#discussion_r511450726



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -1407,7 +1414,9 @@ def test_find_executable_task_instances_task_concurrency(self):  # pylint: disab
         session = settings.Session()
 
         scheduler.dagbag.bag_dag(dag, root_dag=dag)
-        scheduler.dagbag.sync_to_db(session=session)
+        # Since we don't want to store the code for the DAG defined in this file
+        with mock.patch.object(settings, "STORE_DAG_CODE", False):

Review comment:
       Do we have this on every case? If so we should do it in setup with a second patcher (or even if most we should do it in setup)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org